From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: New undo element (fun . args) Date: Mon, 07 Feb 2005 09:23:39 +0100 Message-ID: References: <87fz0jyn19.fsf-monnier+emacs@gnu.org> <87mzunvyki.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1107766377 22280 80.91.229.2 (7 Feb 2005 08:52:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 7 Feb 2005 08:52:57 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 07 09:52:57 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Cy4dV-00062J-Iv for ged-emacs-devel@m.gmane.org; Mon, 07 Feb 2005 09:52:49 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Cy4ra-0001kz-MU for ged-emacs-devel@m.gmane.org; Mon, 07 Feb 2005 04:07:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Cy4hy-0007v1-WE for emacs-devel@gnu.org; Mon, 07 Feb 2005 03:57:27 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Cy4hu-0007sj-1u for emacs-devel@gnu.org; Mon, 07 Feb 2005 03:57:24 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Cy4ht-0007hr-Ac for emacs-devel@gnu.org; Mon, 07 Feb 2005 03:57:21 -0500 Original-Received: from [212.88.64.25] (helo=mail-relay.sonofon.dk) by monty-python.gnu.org with smtp (Exim 4.34) id 1Cy4BH-0007fb-1l for emacs-devel@gnu.org; Mon, 07 Feb 2005 03:23:39 -0500 Original-Received: (qmail 55648 invoked from network); 7 Feb 2005 08:23:35 -0000 Original-Received: from unknown (HELO kfs-l.imdomain.dk.cua.dk) (213.83.150.2) by 0 with SMTP; 7 Feb 2005 08:23:35 -0000 Original-To: rms@gnu.org In-Reply-To: (Richard Stallman's message of "Sat, 05 Feb 2005 12:39:26 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: main.gmane.org gmane.emacs.devel:32988 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:32988 Richard Stallman writes: > So whether that last undo command added anything to buffer-undo-list > or not doesn't seem relevant, as the head of the buffer undo list > should be in the undo-equiv-table in both cases, > > If an undo command does not generate any undo entries, it will have to > put into undo-equiv-table a head-of-list that was produced by some > other command, which may not have been an undo command. That is > certainly not supposed to happen. I see, yes. > So this would be a problem only in the case where (apply ...) is the > only action between two undo boundaries. To work around this, it seems > to be sufficient to add just one element at the end of Fprimitive_undo > in case the undo list hasn't changed at all. > > Yes, I think so. I'll change it to do so. > > BTW, I suppose that the apply undo function is not allowed to change > current buffer. > > Yes it can. That is why it can specify a DELTA. I know. What I meant was this: I suppose that the apply undo function is not allowed to have SWITCHED BUFFER upon return. -- Kim F. Storm http://www.cua.dk