* Obsolete code in sregex.el @ 2005-06-06 12:01 Kim F. Storm 2005-06-06 13:04 ` Stefan Monnier 2005-06-06 16:37 ` Richard Stallman 0 siblings, 2 replies; 6+ messages in thread From: Kim F. Storm @ 2005-06-06 12:01 UTC (permalink / raw) Cc: emacs-devel I noticed the following declarations in sregex.el. But I don't see any references to them, so maybe they can be deleted? ;; Compatibility code for when we didn't have shy-groups (defvar sregex--current-sregex nil) (defun sregex-info () nil) (defmacro sregex-save-match-data (&rest forms) (cons 'save-match-data forms)) (defun sregex-replace-match (r &optional f l str subexp x) (replace-match r f l str subexp)) (defun sregex-match-string (c &optional i x) (match-string c i)) (defun sregex-match-string-no-properties (count &optional in-string sregex) (match-string-no-properties count in-string)) (defun sregex-match-beginning (count &optional sregex) (match-beginning count)) (defun sregex-match-end (count &optional sregex) (match-end count)) (defun sregex-match-data (&optional sregex) (match-data)) (defun sregex-backref-num (n &optional sregex) n) -- Kim F. Storm <storm@cua.dk> http://www.cua.dk ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Obsolete code in sregex.el 2005-06-06 12:01 Obsolete code in sregex.el Kim F. Storm @ 2005-06-06 13:04 ` Stefan Monnier 2005-06-06 17:28 ` Bob Glickstein 2005-06-06 16:37 ` Richard Stallman 1 sibling, 1 reply; 6+ messages in thread From: Stefan Monnier @ 2005-06-06 13:04 UTC (permalink / raw) Cc: Bob Glickstein, emacs-devel > I noticed the following declarations in sregex.el. But I don't see > any references to them, so maybe they can be deleted? As the comment indicates this is compatibility code to interact with code that used sregex before we introduced shy-groups. There is no such code in Emacs. There may not be any such code in the rest of the world either, but I'm not in a position to assess it, My gut feeling is that it's indeed safe to throw it away. Stefan ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Obsolete code in sregex.el 2005-06-06 13:04 ` Stefan Monnier @ 2005-06-06 17:28 ` Bob Glickstein 0 siblings, 0 replies; 6+ messages in thread From: Bob Glickstein @ 2005-06-06 17:28 UTC (permalink / raw) Cc: Bob Glickstein, emacs-devel, Kim F. Storm On Mon, 2005-06-06 at 09:04 -0400, Stefan Monnier wrote: > My gut feeling is that it's indeed safe to throw it away. No objections here. Cheers, - Bob ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Obsolete code in sregex.el 2005-06-06 12:01 Obsolete code in sregex.el Kim F. Storm 2005-06-06 13:04 ` Stefan Monnier @ 2005-06-06 16:37 ` Richard Stallman 2005-06-06 22:33 ` Kim F. Storm 1 sibling, 1 reply; 6+ messages in thread From: Richard Stallman @ 2005-06-06 16:37 UTC (permalink / raw) Cc: bobg+sregex, emacs-devel I noticed the following declarations in sregex.el. But I don't see any references to them, so maybe they can be deleted? Could you please mark them obsolete? We can delete them in the following release. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Obsolete code in sregex.el 2005-06-06 16:37 ` Richard Stallman @ 2005-06-06 22:33 ` Kim F. Storm 2005-06-08 12:01 ` Richard Stallman 0 siblings, 1 reply; 6+ messages in thread From: Kim F. Storm @ 2005-06-06 22:33 UTC (permalink / raw) Cc: bobg+sregex, emacs-devel Richard Stallman <rms@gnu.org> writes: > I noticed the following declarations in sregex.el. But I don't see > any references to them, so maybe they can be deleted? > > Could you please mark them obsolete? We can delete them in the > following release. Bob Glickstein says that it would be ok to remove them. -- Kim F. Storm <storm@cua.dk> http://www.cua.dk ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Obsolete code in sregex.el 2005-06-06 22:33 ` Kim F. Storm @ 2005-06-08 12:01 ` Richard Stallman 0 siblings, 0 replies; 6+ messages in thread From: Richard Stallman @ 2005-06-08 12:01 UTC (permalink / raw) Cc: bobg+sregex, emacs-devel > Could you please mark them obsolete? We can delete them in the > following release. Bob Glickstein says that it would be ok to remove them. I won't put up a fight to delay removing them. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-06-08 12:01 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2005-06-06 12:01 Obsolete code in sregex.el Kim F. Storm 2005-06-06 13:04 ` Stefan Monnier 2005-06-06 17:28 ` Bob Glickstein 2005-06-06 16:37 ` Richard Stallman 2005-06-06 22:33 ` Kim F. Storm 2005-06-08 12:01 ` Richard Stallman
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).