From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Code inspection: W32 specific problems Date: Mon, 18 Jul 2005 14:29:30 +0200 Message-ID: References: <42D94106.6010500@comcast.net> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1121690057 17217 80.91.229.2 (18 Jul 2005 12:34:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 18 Jul 2005 12:34:17 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 18 14:34:09 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DuUo3-00042h-HF for ged-emacs-devel@m.gmane.org; Mon, 18 Jul 2005 14:33:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DuUpy-0006Bo-RP for ged-emacs-devel@m.gmane.org; Mon, 18 Jul 2005 08:35:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DuUoa-0005yu-ST for emacs-devel@gnu.org; Mon, 18 Jul 2005 08:33:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DuUoP-0005sj-8D for emacs-devel@gnu.org; Mon, 18 Jul 2005 08:33:35 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DuUoN-0005rq-Fu for emacs-devel@gnu.org; Mon, 18 Jul 2005 08:33:31 -0400 Original-Received: from [195.41.46.237] (helo=pfepc.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DuUtc-0005uP-FD; Mon, 18 Jul 2005 08:38:56 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepc.post.tele.dk (Postfix) with SMTP id 8EDE0262886; Mon, 18 Jul 2005 14:29:38 +0200 (CEST) Original-To: David Hunter In-Reply-To: <42D94106.6010500@comcast.net> (David Hunter's message of "Sat, 16 Jul 2005 13:16:54 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:41045 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:41045 David Hunter writes: > Eli Zaretskii wrote: >> As for Qw32_charset_default and Vx_hand_shape, someone with more >> knowledge in the w32 code than myself should look at this. > > The declaration for Vx_hand_shape may be removed. > > Qw32_charset_default was declared in w32term.c rev 1.62 in early >2000, but was not defined there either. It is potentially used by >several codepaths, notably in enum_font_cb2(). The related symbol >'w32-charset-default' also exists in documentation. It should be >defined. What about its initial value? Is it always set from lisp before first usage? > > Here's a patch. Eli, will you handle this? -- Kim F. Storm http://www.cua.dk