From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: [david.reitter@gmail.com: vertical-motion fails when tab in line] Date: Wed, 14 Jun 2006 01:01:28 +0200 Message-ID: References: <87bqsxrt9i.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1150239857 29823 80.91.229.2 (13 Jun 2006 23:04:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 13 Jun 2006 23:04:17 +0000 (UTC) Cc: David Reitter , rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 14 01:04:14 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FqHvb-0003Lb-B2 for ged-emacs-devel@m.gmane.org; Wed, 14 Jun 2006 01:04:07 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FqHva-0000fg-VL for ged-emacs-devel@m.gmane.org; Tue, 13 Jun 2006 19:04:06 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FqHvQ-0000fO-Ft for emacs-devel@gnu.org; Tue, 13 Jun 2006 19:03:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FqHvP-0000fC-PG for emacs-devel@gnu.org; Tue, 13 Jun 2006 19:03:56 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FqHvP-0000f9-My for emacs-devel@gnu.org; Tue, 13 Jun 2006 19:03:55 -0400 Original-Received: from [195.41.46.237] (helo=pfepc.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FqI4R-0002bg-DV; Tue, 13 Jun 2006 19:13:15 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk [80.62.38.68]) by pfepc.post.tele.dk (Postfix) with SMTP id A8FC18A0002; Wed, 14 Jun 2006 01:03:48 +0200 (CEST) Original-To: Chong Yidong In-Reply-To: <87bqsxrt9i.fsf@stupidchicken.com> (Chong Yidong's message of "Tue, 13 Jun 2006 11:04:57 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55872 Archived-At: Chong Yidong writes: > The problem here is that in Fvertical_motion line 2092, after we call > reseat_at_previous_visible_line_start (&it), the value of > it.continuation_lines_width is not reset to zero. This screws up the > calculation of tab stops if it.continuation_lines_width is non-zero > and there are tabs present in the continued line. Thanks for debugging this. > > One solution is to reset it->continuation lines_width to zero in > reseat_at_previous_visible_line_start (and probably > reseat_at_next_visible_line_start too.) This seems like the proper > fix, but I'd like to get some confirmation from people more familiar > with redisplay: More generally, we could set it->continuation_lines_width = 0 in back_to_previous_line_start and forward_to_next_line_start (if we find a newline). -- Kim F. Storm http://www.cua.dk