From: Tom Tromey <tromey@redhat.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: odd code in dbusbind.c
Date: Sun, 30 Dec 2007 14:05:35 -0700 [thread overview]
Message-ID: <m3tzlzevvk.fsf@fleche.redhat.com> (raw)
In-Reply-To: <87d4sow4rc.fsf@gmx.de> (Michael Albinus's message of "Sun\, 30 Dec 2007 17\:01\:43 +0100")
>>>>> "Michael" == Michael Albinus <michael.albinus@gmx.de> writes:
Michael> Thanks a lot for your review. All mentioned points shall be
Michael> fixed now.
Thanks!
Here's one more I ran into -- I was copying parts of dbusbind.c for my
status icon patch, and this looked odd. Other places in Emacs seem to
use non-static input_event structs this way. kbd_buffer_store_event
could be clearer about whether the event is copied or the pointer is
stored, though...
Tom
Index: dbusbind.c
===================================================================
RCS file: /sources/emacs/emacs/src/dbusbind.c,v
retrieving revision 1.14
diff -u -c -r1.14 dbusbind.c
cvs diff: conflicting specifications of output style
*** dbusbind.c 30 Dec 2007 15:55:29 -0000 1.14
--- dbusbind.c 30 Dec 2007 21:32:56 -0000
***************
*** 962,968 ****
{
Lisp_Object args, key, value;
struct gcpro gcpro1;
! static struct input_event event;
DBusConnection *connection;
DBusMessage *dmessage;
DBusMessageIter iter;
--- 962,968 ----
{
Lisp_Object args, key, value;
struct gcpro gcpro1;
! struct input_event event;
DBusConnection *connection;
DBusMessage *dmessage;
DBusMessageIter iter;
next prev parent reply other threads:[~2007-12-30 21:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-29 22:41 odd code in dbusbind.c Tom Tromey
2007-12-30 16:01 ` Michael Albinus
2007-12-30 21:05 ` Tom Tromey [this message]
2007-12-31 10:29 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3tzlzevvk.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).