From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: trunk r113804: * decompress.c: Fix bugs with large buffers and weird inputs. Date: Tue, 13 Aug 2013 17:10:29 +0200 Message-ID: References: <520A4ABC.2000204@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1376406664 11167 80.91.229.3 (13 Aug 2013 15:11:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Aug 2013 15:11:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 13 17:11:06 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V9GFR-0004Sk-7A for ged-emacs-devel@m.gmane.org; Tue, 13 Aug 2013 17:11:01 +0200 Original-Received: from localhost ([::1]:53485 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9GFQ-0003PM-Hq for ged-emacs-devel@m.gmane.org; Tue, 13 Aug 2013 11:11:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9GFH-0003Ev-BM for emacs-devel@gnu.org; Tue, 13 Aug 2013 11:10:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V9GFB-0003Mk-Oc for emacs-devel@gnu.org; Tue, 13 Aug 2013 11:10:51 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:40309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9GFB-0003MJ-6m for emacs-devel@gnu.org; Tue, 13 Aug 2013 11:10:45 -0400 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1V9GEv-0005yy-Fa; Tue, 13 Aug 2013 17:10:29 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEViUlj///X+/vbz7+T+ /fIYDRP///c7F+YMAAABzElEQVQ4jXWTW47bMAxFBRheABuB/2mBfgewZwGqBH0bGGQBTATtfwm9 JGUnmckoyEvHl2+G8uUkosLUJNi/eNwy9U7cpTvAU4AUiQWgM95BH1M5pcTELHrZHcSEV4mEs98a SGcHxQA9QD2TupBEYgrmXaGW8zLOmuuuIOosFttieB0gWXQ5HOcJQJHn6zjbDqr6ujnYXgAsCd0V bAGfWxngX8e9nHYwHyDxWYhOs5MQDlBgqaRs4DrPAHWPihWEB0hWSAWtlAFgbNNURx6tvYLehiLG sicIkGN9A65QUIoe1Q0dfwPQUHTJwawgcxqmfrfSDISLZp6pAEhI1JsmCDAtMxRrdFPIs0UDWhAo lqJAXsEFiqVKQd8NNIsqLAucoFYF9XPw18A2QMLIDMXII1ijVkiIRBvVijcqWFQ2y9xc4cMwAOuw UqjSY9mjsp6T6JBb2aXen0AC4Oimkvr41KAURGoMU/0mnf9oHhMyV5AoqkKQP99NMV0MwHWP4YyB o+qmpg8F8E4+cL3KCQWckDm+dIGs7JirKi0/9tkXVMNFeCddDNucvA5Qu6Bkv/rXo3lw55c7n8T6 7dmfgZuyDX4HhuJgt2/gWYbf/wHKajKHWXbQWgAAAABJRU5ErkJggg== X-Now-Playing: =?iso-8859-1?Q?=B5-Ziq's?= _Somerset Avenue Tracks (1992-1995) (1)_: "Spooky Tooth" X-Hashcash: 1:23:130813:eggert@cs.ucla.edu::fvDi54rysxUYTtAE:0000000000000000000000000000000000000000000EbID X-Hashcash: 1:23:130813:emacs-devel@gnu.org::9kqx8rBRrKeHl7l+:000000000000000000000000000000000000000000j5LO In-Reply-To: <520A4ABC.2000204@cs.ucla.edu> (Paul Eggert's message of "Tue, 13 Aug 2013 08:03:24 -0700") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) X-MailScanner-ID: 1V9GEv-0005yy-Fa MailScanner-NULL-Check: 1377011429.61363@eJGny13kWMvtFQeIkIzfZQ X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162661 Archived-At: Paul Eggert writes: > Lars Magne Ingebrigtsen wrote: >> Does Emacs compile on any systems >> where UINT_MAX is smaller than 16384? > > No, that code was just trying to remind the reader that > the value cannot exceed UINT_MAX due to zlib constraints. > I redid the code and comment a bit to try to make this clearer, > in trunk bzr 113845. I think writing 1 << 14 and then checking whether that's larger than UINT_MAX is still pretty unclear. My first thought, at least, was "geez, he's making a HUGE buffer gap", until I started doing the math. Please just write 16384 or something. It's not like it's a magical number. -- (domestic pets only, the antidote for overdose, milk.) No Gnus T-Shirt for sale: http://ingebrigtsen.no/no.php and http://lars.ingebrigtsen.no/2013/08/twenty-years-of-september.html