From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r113804: * decompress.c: Fix bugs with large buffers and weird inputs.
Date: Tue, 13 Aug 2013 17:10:29 +0200 [thread overview]
Message-ID: <m3txit1va2.fsf@stories.gnus.org> (raw)
In-Reply-To: <520A4ABC.2000204@cs.ucla.edu> (Paul Eggert's message of "Tue, 13 Aug 2013 08:03:24 -0700")
Paul Eggert <eggert@cs.ucla.edu> writes:
> Lars Magne Ingebrigtsen wrote:
>> Does Emacs compile on any systems
>> where UINT_MAX is smaller than 16384?
>
> No, that code was just trying to remind the reader that
> the value cannot exceed UINT_MAX due to zlib constraints.
> I redid the code and comment a bit to try to make this clearer,
> in trunk bzr 113845.
I think writing 1 << 14 and then checking whether that's larger than
UINT_MAX is still pretty unclear. My first thought, at least, was
"geez, he's making a HUGE buffer gap", until I started doing the math.
Please just write 16384 or something. It's not like it's a magical
number.
--
(domestic pets only, the antidote for overdose, milk.)
No Gnus T-Shirt for sale: http://ingebrigtsen.no/no.php
and http://lars.ingebrigtsen.no/2013/08/twenty-years-of-september.html
next prev parent reply other threads:[~2013-08-13 15:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1V8elS-0003CG-7L@vcs.savannah.gnu.org>
2013-08-13 12:08 ` trunk r113804: * decompress.c: Fix bugs with large buffers and weird inputs Lars Magne Ingebrigtsen
2013-08-13 12:19 ` Andreas Schwab
2013-08-13 15:03 ` Paul Eggert
2013-08-13 15:10 ` Lars Magne Ingebrigtsen [this message]
2013-08-13 16:21 ` Lars Magne Ingebrigtsen
2013-08-13 21:47 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3txit1va2.fsf@stories.gnus.org \
--to=larsi@gnus.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).