From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Generalize start-process with keyword args Date: Thu, 19 Mar 2015 16:36:06 +0900 Message-ID: References: <87d24d3uwz.fsf-ueno@gnu.org> <83pp87y6iu.fsf@gnu.org> <83mw3bxz9f.fsf@gnu.org> <83k2yfx8zi.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426750618 19645 80.91.229.3 (19 Mar 2015 07:36:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Mar 2015 07:36:58 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 19 08:36:43 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YYV0R-0000uH-8V for ged-emacs-devel@m.gmane.org; Thu, 19 Mar 2015 08:36:39 +0100 Original-Received: from localhost ([::1]:37521 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYV0Q-0003SD-Ga for ged-emacs-devel@m.gmane.org; Thu, 19 Mar 2015 03:36:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYV04-0003OJ-Gd for emacs-devel@gnu.org; Thu, 19 Mar 2015 03:36:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYV02-0001wI-58 for emacs-devel@gnu.org; Thu, 19 Mar 2015 03:36:16 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYV02-0001wE-2C for emacs-devel@gnu.org; Thu, 19 Mar 2015 03:36:14 -0400 Original-Received: from du-a.org ([2001:e41:db5e:fb14::1]:34922 helo=localhost.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1YYV00-0005An-Ph; Thu, 19 Mar 2015 03:36:13 -0400 In-Reply-To: (Stefan Monnier's message of "Wed, 18 Mar 2015 09:03:19 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:184010 Archived-At: Stefan Monnier writes: >> +If @var{coding} is @code{nil}, the coding system chosen for decoding >> +output is @code{undecided}, meaning deduce the encoding from the >> +actual data. > > Doesn't it also depend on coding-system-for-read and coding-system-for-write? Also `find-operation-coding-system' and multibyteness of the buffer. But do we really want to describe all the possibilities there? Similarly, since the make-*-process functions share common keywords (:filter, :sentinel, etc), can we arrange them in a single section and refer to it from those function documentation? > Any reason why you nested the "if/elseif/else" inside the outer "if" > instead of having a 4-way "if/elseif/elseif/else"? > [ Either way is fine by me, I'm just being curious here. ] Maybe I just wanted to have clear distinction between nil and non-nil cases, since we changed the meaning during the review. Fixed. Regards, -- Daiki Ueno