* Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt
[not found] ` <20190616141013.5EE5F20B45@vcs0.savannah.gnu.org>
@ 2019-06-16 19:41 ` Stefan Monnier
2019-06-16 19:43 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2019-06-16 19:41 UTC (permalink / raw)
To: emacs-devel; +Cc: Lars Ingebrigtsen
> +(require 'cl-extra)
Please require cl-lib instead: the division into cl-(lib|macs|seq|extra)
is supposed to be an internal implementation detail.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt
2019-06-16 19:41 ` [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt Stefan Monnier
@ 2019-06-16 19:43 ` Lars Ingebrigtsen
2019-06-16 19:52 ` Lars Ingebrigtsen
2019-06-16 20:24 ` Stefan Monnier
0 siblings, 2 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2019-06-16 19:43 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> +(require 'cl-extra)
>
> Please require cl-lib instead: the division into cl-(lib|macs|seq|extra)
> is supposed to be an internal implementation detail.
That's what I had originally, but then I got this warning:
In end of data:
emacs-lisp/eieio-opt.el:359:1:Warning: the function `cl--describe-class' is
not known to be defined.
Perhaps because it's an internal(ish) function?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt
2019-06-16 19:43 ` Lars Ingebrigtsen
@ 2019-06-16 19:52 ` Lars Ingebrigtsen
2019-06-16 19:55 ` Lars Ingebrigtsen
2019-06-16 20:24 ` Stefan Monnier
1 sibling, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2019-06-16 19:52 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> +(require 'cl-extra)
>>
>> Please require cl-lib instead: the division into cl-(lib|macs|seq|extra)
>> is supposed to be an internal implementation detail.
>
> That's what I had originally, but then I got this warning:
>
> In end of data:
> emacs-lisp/eieio-opt.el:359:1:Warning: the function `cl--describe-class' is
> not known to be defined.
>
> Perhaps because it's an internal(ish) function?
Hm... Perhaps that should have been a call to cl-describe-type instead,
despite what
(define-obsolete-function-alias 'eieio-help-class 'cl--describe-class "25.1")
says... I'll do some testing.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt
2019-06-16 19:52 ` Lars Ingebrigtsen
@ 2019-06-16 19:55 ` Lars Ingebrigtsen
0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2019-06-16 19:55 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Hm... Perhaps that should have been a call to cl-describe-type instead,
> despite what
>
> (define-obsolete-function-alias 'eieio-help-class 'cl--describe-class "25.1")
>
> says... I'll do some testing.
Hm... nope. That function does
(save-excursion
(with-help-window (help-buffer)
(with-current-buffer standard-output
(let ((class (cl-find-class type)))
(if class
(cl--describe-class type class)
which isn't what we want...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt
2019-06-16 19:43 ` Lars Ingebrigtsen
2019-06-16 19:52 ` Lars Ingebrigtsen
@ 2019-06-16 20:24 ` Stefan Monnier
2019-06-16 20:26 ` Lars Ingebrigtsen
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2019-06-16 20:24 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
>>> +(require 'cl-extra)
>> Please require cl-lib instead: the division into cl-(lib|macs|seq|extra)
>> is supposed to be an internal implementation detail.
> That's what I had originally, but then I got this warning:
> In end of data:
> emacs-lisp/eieio-opt.el:359:1:Warning: the function `cl--describe-class' is
> not known to be defined.
> Perhaps because it's an internal(ish) function?
Ah, yes, it's not autoloaded because it's internal.
I guess cl-extra is OK in that case, but please add a comment to
explain it.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt
2019-06-16 20:24 ` Stefan Monnier
@ 2019-06-16 20:26 ` Lars Ingebrigtsen
0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2019-06-16 20:26 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I guess cl-extra is OK in that case, but please add a comment to
> explain it.
OK; done.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-16 20:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190616141010.24607.84378@vcs0.savannah.gnu.org>
[not found] ` <20190616141013.5EE5F20B45@vcs0.savannah.gnu.org>
2019-06-16 19:41 ` [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt Stefan Monnier
2019-06-16 19:43 ` Lars Ingebrigtsen
2019-06-16 19:52 ` Lars Ingebrigtsen
2019-06-16 19:55 ` Lars Ingebrigtsen
2019-06-16 20:24 ` Stefan Monnier
2019-06-16 20:26 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).