From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: master 32e790f: Implement NTLM server for ntlm.el testing Date: Fri, 19 Feb 2021 17:15:50 -0500 Message-ID: References: <20210219014652.27375.17475@vcs0.savannah.gnu.org> <20210219014654.0131020DFB@vcs0.savannah.gnu.org> <877dn48kw8.fsf@gmx.de> <87a6s0vtuh.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4379"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 19 23:17:26 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDE5V-00010W-1G for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Feb 2021 23:17:25 +0100 Original-Received: from localhost ([::1]:41618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDE5U-0002BS-0h for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Feb 2021 17:17:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDE45-0001QI-TL for emacs-devel@gnu.org; Fri, 19 Feb 2021 17:15:58 -0500 Original-Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]:40471) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lDE42-0003cV-T6 for emacs-devel@gnu.org; Fri, 19 Feb 2021 17:15:57 -0500 Original-Received: by mail-qt1-x830.google.com with SMTP id f17so5096598qth.7 for ; Fri, 19 Feb 2021 14:15:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Gx/PtjfCe59NsXqjGMflHKvtWX46IEWtwAHrKZ3A8bg=; b=gsHl7saIptbtKTmF37BcWLSVWmSTFHTTz2vEPzjKDsqc3FwF1ouAr1xR5u84jiI4hc lfBJzlNwisKkFBOaDJm4+sclO5CGqxrc4Y2Yrz8tt4KFKvgvK4gLAbUzAnoZ3ngyWj3R 2Kp6gcyKZHH0VfwKfjmjT00GVUvGt0GI/pWASMBulywrR5xVnnZx9O4w0An/hcenPtpo 3hdDu8E1MmaR+wWFDvOiOykv/ke0qX2Ve0jF+QVE8VQTqf9TDN1YPFLkmj5p760WsKb/ 6ny++qChH/tC8noRSkvzN9BQ+OlJhOiqi1GvkKIv7KvGr8wfEGaopu/SsQSGs9WKAij0 eM2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Gx/PtjfCe59NsXqjGMflHKvtWX46IEWtwAHrKZ3A8bg=; b=LwbH6/9VCistzwvTXyOptR96KfdyZt6C+/LBcD0lgM4xinyjOJ2D3JjnzBKBCXuU6k 7HlBz0ET/v7nFygIZiuP5w4ajZMz2fhPshgerMUxBqKO/ArmaYLBbRcVsfbUYhMVZt20 vbNaAxRoD34gPF19NhpW1/+Qm14PqYNr/K40tO78S+BzkYiwjIATcHBjbzGpJLYo4f8Z L7G/kV9K5Fa8QI67cDEiozpuXuJrnbw6YdOIM3NIrzSVHWEKlVc1bUZfv51x75bMNKC+ cwRus7mwRfHeYnTHbWsr4//+LjyN0PJt+xeMt1fs38kZNy96P07jKSrVlk1Md3y3EbK+ adDQ== X-Gm-Message-State: AOAM533P9/8PYCST2Ian3wIEZY9bxloq32Tt5PjqbBWtfKGks2rxdPLS I/Gq4ZCxxMJgeCFLzeC87CmujnVBX7uzFGy5 X-Google-Smtp-Source: ABdhPJw5iWmqLgUZe55p8f36HE/FdF8Rh2eppS+7IYQpeBY0UvUeSk9anc1TITA1xnGWVJteWxNSrw== X-Received: by 2002:ac8:4b6e:: with SMTP id g14mr10852125qts.216.1613772952106; Fri, 19 Feb 2021 14:15:52 -0800 (PST) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id h22sm6096430qth.55.2021.02.19.14.15.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Feb 2021 14:15:51 -0800 (PST) In-Reply-To: <87a6s0vtuh.fsf@gmx.de> (Michael Albinus's message of "Fri, 19 Feb 2021 18:40:54 +0100") Received-SPF: none client-ip=2607:f8b0:4864:20::830; envelope-from=fitzsim@fitzsim.org; helo=mail-qt1-x830.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265285 Archived-At: Hi Michael, Michael Albinus writes: > Thomas Fitzsimmons writes: [...] >>> Could you pls provide more advanced checks for dependencies? For >>> example, instead of >>> >>> (and (featurep 'url-http-ntlm) (featurep 'web-server)) >>> >>> you could check a proper version of the packages? >> >> I'd rather not add the complexity, e.g., depending on package.el. >> Beyond this first requirement to update web-server to the latest, I >> don't see how a version check would be useful. I tried to implement a >> specific check for the ws-parse functionality, but I couldn't find an >> easy way of confirming the new NTLM path. > > That's just *this* case. Other changes might apply to your packages in > the future, which require newer package code. And I'm thinking also > about a more general approach for other Emacs tests, how to use GNU ELPA > packages as dependency. OK, makes sense. > And you don't need package.el. Require lisp-mnt, then you could do > something like [...] OK, thanks. I've pushed a variation on your suggestion that checks for the NTLM ws-parse functionality (web-server's GNU ELPA version has not been bumped yet). >>> Warning (emacs): Cannot find one or more GNU ELPA packages >>> Warning (emacs): Skipping NTLM authentication tests >>> Warning (emacs): See GNU_ELPA_DIRECTORY in test/README >>> Running 3 tests (2021-02-19 10:26:00+0100, selector `(not (tag :unstable))') >>> skipped 1/3 ntlm-authentication (0.000133 sec) >>> skipped 2/3 ntlm-authentication-old-compatibility-level (0.000097 sec) >>> passed 3/3 ntlm-time-to-timestamp (0.000136 sec) >>> >>> Is it necessary to be such chatty? The tests are skipped (like other >>> tests), fine. >> >> I debated not putting in those warnings. I wanted to point out why the >> tests are being skipped, and in particular that it's easy to have them >> not be skipped if you have a GNU ELPA checkout (versus tests that are >> unavoidably skipped because they depend on a different OS or >> architecture). >> >> Basically, I'd like to encourage Emacs maintainers to not skip these >> tests; the reason I wrote them was to prevent regressions like Bug#43566 >> (merged with Bug#44195 and Bug#44439), which broke all uses of NTLM in >> an Emacs point release. > > Again, not every Emacs developer has an ELPA checkout. And we shouldn't > be bossy to them. Sure, I removed the warnings. Thomas