From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] EUDC email addresses via completion-at-point in message-mode Date: Fri, 29 Apr 2022 10:43:11 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7297"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Filipp Gunbin , emacs-devel@gnu.org To: Alexander Adolf Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 29 16:54:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkS0s-0001as-2c for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 16:54:30 +0200 Original-Received: from localhost ([::1]:51780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkS0q-0005rH-SS for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 10:54:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkRq3-0002tx-6N for emacs-devel@gnu.org; Fri, 29 Apr 2022 10:43:21 -0400 Original-Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]:37531) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nkRq0-00008V-7b for emacs-devel@gnu.org; Fri, 29 Apr 2022 10:43:18 -0400 Original-Received: by mail-qt1-x831.google.com with SMTP id h3so1306486qtn.4 for ; Fri, 29 Apr 2022 07:43:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/lpG/oOuxTFWtmBM9XimXzmlwvckBqCQb7SgTS0Yz1E=; b=JEHQSL2Pa/NJNbvYaLvNdZULXCj61ZAnlR5q+c+Xfymi9tYHRvdr/5wmWzQrp0Iysr o95JcXRxIVsy6xgnSz0EsCBpYneT2ccioE5p3/YIO0bbqDnqyF/J+4+UMgVmbDvvym9a ILm6fth49XPDsOwKexVmUe51PgskcUs6Hi3JLi/l7dXDdD909vK++/MyeT6bgAtUvim4 2vihtW8P1WxW9mS6CfJyL4MDhpeUunfUlaG1sh9hPdsGgy2dvvPOAaMy5pKUS+zCS0Mi E+Ir+V+ZMEJRWjHb2HWpC8KRjrKhsUn2acMs6aR3NNXokf8Fs1Yyqd911Rl8cXo8Sc7K kV7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/lpG/oOuxTFWtmBM9XimXzmlwvckBqCQb7SgTS0Yz1E=; b=Ig+rCE1GGnN8iZj3xxv4iBUsrzELepR6L701XfFyTNpREWLgSVLB4QScgt0173PA/W Gd05u+8GjBKQz9GLHKhK4esi5cxvQtWjtEujlh2v6OZISi/y3rXJ2GGcrAY33ZHZi0Ty HhJddYRKq2U3KOoj/HFq1OLibwRaxvr8eTp3Ys4saqpehUgcLkJ1edpZaZyYJ3w2mAOr h5Pq8/M1D/Lm/Am7SddTK6Iyaj2V4cjFjcBWMkt8BJjaACeGy585CeVYcWp0vDrTRc3N 7R5WLWzQLEeQfm6gn4bc9uFt+7VdIfUd4QzZ7MNG45Fh0cTlwvrwTo+qCpFS1Chj8Blw vj+A== X-Gm-Message-State: AOAM5323HECgd90E/rWycefOmBaemmXZ5alm0Agwd5Oq5QqnEBUI6OvU tAvtk4+k9eIpcBVl75KTNYc7CTw13P6oPw== X-Google-Smtp-Source: ABdhPJwhwaG+rhYSdNTXNyNjWhlk683p5tAPdPk1MN9st2ByJ8q/aXiXLlckUmawQOgLEP19ZZOWaQ== X-Received: by 2002:ac8:598b:0:b0:2f3:7ff6:f4d5 with SMTP id e11-20020ac8598b000000b002f37ff6f4d5mr12629913qte.273.1651243393420; Fri, 29 Apr 2022 07:43:13 -0700 (PDT) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id s14-20020a05620a254e00b0069fb8830b08sm736112qko.134.2022.04.29.07.43.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Apr 2022 07:43:12 -0700 (PDT) In-Reply-To: (Alexander Adolf's message of "Thu, 28 Apr 2022 19:15:15 +0200") Received-SPF: pass client-ip=2607:f8b0:4864:20::831; envelope-from=fitzsim@fitzsim.org; helo=mail-qt1-x831.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288997 Archived-At: Hi Alexander, Alexander Adolf writes: [...] > Many thanks and looking forward to your thoughts, Thanks for the updated patch. One open issue I had when I tested the prior patch was the fact that repeated completion attempts would query the LDAP search on each attempt, even if the completion table could already have been populated with all relevant LDAP entries. Can you test that behaviour, perhaps with the macOS contact EUDC backend that you use, to see what I mean? Is there a way the default completion-at-point implementation can do the same as eudc-expand-try-all, where the final completion selection is done from the collected list of options, rather than requerying all the backends each time TAB is pressed? Thanks, Thomas