From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Fix to long-standing crashes in GC Date: 31 May 2004 22:21:36 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <40A3BC23.8060000@math.ku.dk> <200405180013.i4I0Ddl15818@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1086034947 12724 80.91.224.253 (31 May 2004 20:22:27 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 31 May 2004 20:22:27 +0000 (UTC) Cc: Luc Teirlinck , rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon May 31 22:22:16 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BUtIW-0007e8-00 for ; Mon, 31 May 2004 22:22:16 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BUtIW-00028C-00 for ; Mon, 31 May 2004 22:22:16 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BUtIi-0004Fd-Q2 for emacs-devel@quimby.gnus.org; Mon, 31 May 2004 16:22:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BUtIb-0004FO-Rd for emacs-devel@gnu.org; Mon, 31 May 2004 16:22:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BUtIa-0004FC-5k for emacs-devel@gnu.org; Mon, 31 May 2004 16:22:21 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BUtIa-0004F9-35 for emacs-devel@gnu.org; Mon, 31 May 2004 16:22:20 -0400 Original-Received: from [195.41.46.236] (helo=pfepb.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BUtHk-000569-2F; Mon, 31 May 2004 16:21:28 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk [80.62.38.68]) by pfepb.post.tele.dk (Postfix) with SMTP id 880995EE04C; Mon, 31 May 2004 22:21:25 +0200 (CEST) Original-To: Stefan Monnier In-Reply-To: Original-Lines: 24 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:24304 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:24304 Stefan Monnier writes: > >> The sweep step simply has to be atomic, just like most of the GC itself > >> (afterall, that's why the mark&sweep algorithm is in the category called > >> "stop-the-world"). > > > True -- but if you try to debug GC errors, I prefer the code to be as > > safe as possible. > > If you want it for debugging purposes, feel free to switch the sweeping > of strings w.r.t the sweeping of cons cells. I've never had to debug in > there, so I wouldn't have any preference either way. As I said, it > shouldn't make any difference w.r.t to correctness. > The two "reasons" why I undid this part of your change were: > - you also moved the sweeping of cons cells to before the sweeping of weak > hash tables, which sounds seriously wrong. > - I started from a full undo of your patch. > Ok, I'll leave things as they are -- and remember the issue if I have to look into GC again later. -- Kim F. Storm http://www.cua.dk