From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.multi-tty,gmane.emacs.devel Subject: Re: Face alias bugs (Re: abort() in keyboard.c) Date: Tue, 19 Apr 2005 10:36:52 +0200 Message-ID: References: <87u0myhffz.fsf@fischman.org> <87vf7deeme.fsf@fischman.org> <87hdivjic5.fsf@fischman.org> <87fyy1d9jx.fsf_-_@fischman.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1113899704 8780 80.91.229.2 (19 Apr 2005 08:35:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 19 Apr 2005 08:35:04 +0000 (UTC) Cc: multi-tty@lists.fnord.hu, emacs-devel@gnu.org Original-X-From: multi-tty-bounces@lists.fnord.hu Tue Apr 19 10:35:01 2005 Return-path: Original-Received: from ninsei.hu ([212.92.23.158] helo=chatsubo.ninsei.hu) by ciao.gmane.org with esmtp (Exim 4.43) id 1DNoAu-0001De-2i for gem-multi-tty@m.gmane.org; Tue, 19 Apr 2005 10:33:41 +0200 Original-Received: from [127.0.0.1] (nixon [127.0.0.1]) by chatsubo.ninsei.hu (Postfix) with ESMTP id AAF861ADB5; Tue, 19 Apr 2005 10:37:28 +0200 (CEST) Original-Received: from mail-relay.sonofon.dk (mail-relay.sonofon.dk [212.88.64.25]) by chatsubo.ninsei.hu (Postfix) with SMTP id 5B7651AD68 for ; Tue, 19 Apr 2005 10:37:20 +0200 (CEST) Original-Received: (qmail 272 invoked from network); 19 Apr 2005 08:37:01 -0000 Original-Received: from unknown (HELO kfs-l.imdomain.dk.cua.dk) (213.83.150.2) by 0 with SMTP; 19 Apr 2005 08:37:01 -0000 Original-To: lorentey@elte.hu (=?utf-8?Q?K=C3=A1roly_L=C5=91rentey?=) In-Reply-To: (=?utf-8?Q?K=C3=A1roly_L=C5=91rentey's?= message of "Wed, 13 Apr 2005 07:48:02 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: multi-tty@lists.fnord.hu X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions of multiple tty support in Emacs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: multi-tty-bounces@lists.fnord.hu Errors-To: multi-tty-bounces@lists.fnord.hu Xref: news.gmane.org gmane.emacs.multi-tty:224 gmane.emacs.devel:36103 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:36103 lorentey@elte.hu (K=C3=A1roly L=C5=91rentey) writes: > I have received a backtrace for an aborted multi-tty session from Ami > Fischman that is relevant to the trunk as well. Thanks for the report and analysis. I have installed a different change for this problem which uses a new safe-get function for the face lookup. I also added a check for alias loops. > > The abort was caused by Emacs entering the debugger during redisplay > because of a property list on a face symbol that was not a well-formed > Lisp list (see frames #23-26 in the backtrace at the bottom). > > Beside the (rare) crash condition, there are other symptoms that are > easier to reproduce. For example (in a recent CVS): > > emacs -q > (setplist 'default (append (symbol-plist 'default) (cons 'foo 'bar))) > C-h i > > > Recursive aliases are fun as well: > > emacs -q > (put 'foo 'face-alias 'default)=20 > (put 'default 'face-alias 'foo) > C-h i > > > The patch below fixes all these problems by protecting the call to > Fget inside resolve_face_name and limiting the number of indirections > during a single face lookup. --=20 Kim F. Storm http://www.cua.dk