From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: ido, Ibuffer, and dropping into Dired Date: Sun, 15 May 2005 01:04:13 +0200 Message-ID: References: <871x894neg.fsf@wigwam.deepwood.net> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1116113583 24342 80.91.229.2 (14 May 2005 23:33:03 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 14 May 2005 23:33:03 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 15 01:33:01 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DX67s-00054q-CW for ged-emacs-devel@m.gmane.org; Sun, 15 May 2005 01:32:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DX69Z-0001Xb-Iu for ged-emacs-devel@m.gmane.org; Sat, 14 May 2005 19:34:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DX61p-0007nU-Qv for emacs-devel@gnu.org; Sat, 14 May 2005 19:26:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DX61n-0007mm-OD for emacs-devel@gnu.org; Sat, 14 May 2005 19:26:40 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DX60b-00078N-4j for emacs-devel@gnu.org; Sat, 14 May 2005 19:25:25 -0400 Original-Received: from [195.41.46.235] (helo=pfepa.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DX5n8-0005SS-F5 for emacs-devel@gnu.org; Sat, 14 May 2005 19:11:30 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk [80.62.38.68]) by pfepa.post.tele.dk (Postfix) with SMTP id B82AB47FE26; Sun, 15 May 2005 01:04:03 +0200 (CEST) Original-To: Daniel Brockman In-Reply-To: <871x894neg.fsf@wigwam.deepwood.net> (Daniel Brockman's message of "Sat, 14 May 2005 21:29:11 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37149 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37149 Daniel Brockman writes: > Not really sure whether this is a bug or a strange feature, but here's > how to reproduce it: > > 1. Enable `ido-mode' and `ido-everywhere' via customize. > 2. Type C-x C-f and verify that C-d drops you into dired. > 3. Enter Ibuffer using M-x ibuffer RET. > 4. Type C-x C-f and note how C-d is now bound to 'ignore. > > I don't see any reason why it should not be possible to drop into > Dired just because C-x C-f was typed in the *Ibuffer* buffer. Does the following patch give good results: *** ido.el 06 May 2005 00:14:45 +0200 1.55 --- ido.el 15 May 2005 01:01:23 +0200 *************** *** 4077,4082 **** --- 4138,4144 ---- ;;; Helper functions for other programs (put 'dired-do-rename 'ido 'ignore) + (put 'ibuffer-find-file 'ido 'find-file) ;;;###autoload (defun ido-read-buffer (prompt &optional default require-match) *************** *** 4111,4117 **** (not (memq this-command ido-read-file-name-non-ido)) (or (null predicate) (eq predicate 'file-exists-p))) (let* (ido-saved-vc-hb ! (ido-context-switch-command 'ignore) (vc-handled-backends (and (boundp 'vc-handled-backends) vc-handled-backends)) (ido-current-directory (ido-expand-directory dir)) (ido-directory-nonreadable (not (file-readable-p ido-current-directory))) --- 4173,4180 ---- (not (memq this-command ido-read-file-name-non-ido)) (or (null predicate) (eq predicate 'file-exists-p))) (let* (ido-saved-vc-hb ! (ido-context-switch-command ! (if (eq (get this-command 'ido) 'find-file) nil 'ignore)) (vc-handled-backends (and (boundp 'vc-handled-backends) vc-handled-backends)) (ido-current-directory (ido-expand-directory dir)) (ido-directory-nonreadable (not (file-readable-p ido-current-directory))) *************** *** 4126,4131 **** --- 4189,4196 ---- (cond ((eq ido-exit 'fallback) (setq filename 'fallback)) + ((eq ido-exit 'dired) + (setq filename ido-current-directory)) (filename (setq filename (concat ido-current-directory filename)))))) -- Kim F. Storm http://www.cua.dk