From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: delete-overlay causes recentering Date: Sun, 15 Apr 2007 22:13:11 +0200 Message-ID: References: <25771086.79401173867519911.JavaMail.www@wwinf4104> <87fy72v2bs.fsf@stupidchicken.com> <87zm5av218.fsf@stupidchicken.com> <873b31e9tq.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1176668022 11438 80.91.229.12 (15 Apr 2007 20:13:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 15 Apr 2007 20:13:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 15 22:13:35 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HdB6N-0000mK-47 for ged-emacs-devel@m.gmane.org; Sun, 15 Apr 2007 22:13:35 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HdBAt-0003Eb-Og for ged-emacs-devel@m.gmane.org; Sun, 15 Apr 2007 16:18:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HdBAp-000397-Nh for emacs-devel@gnu.org; Sun, 15 Apr 2007 16:18:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HdBAo-00038X-Bx for emacs-devel@gnu.org; Sun, 15 Apr 2007 16:18:11 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HdBAo-00038U-5y for emacs-devel@gnu.org; Sun, 15 Apr 2007 16:18:10 -0400 Original-Received: from pfepa.post.tele.dk ([195.41.46.235]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HdB6G-0001tV-JU for emacs-devel@gnu.org; Sun, 15 Apr 2007 16:13:28 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx19.adsl-dhcp.tele.dk [80.62.38.68]) by pfepa.post.tele.dk (Postfix) with SMTP id 7A83BFAC036; Sun, 15 Apr 2007 22:13:27 +0200 (CEST) In-Reply-To: <873b31e9tq.fsf@stupidchicken.com> (Chong Yidong's message of "Sun\, 15 Apr 2007 15\:06\:41 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.97 (gnu/linux) X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:69470 Archived-At: Chong Yidong writes: > If we use the original values of BEG_UNCHANGED and END_UNCHANGED, > before it is "updated" by the above code, the spurious recentering > does not take place. The original (2006) test case also seems to > behave OK -- in that case, we recenter correctly. However, I can't be > certain this is correct because I don't know the original > justification for the above check. The justification was to make BEG_UNCHANGED and END_UNCHANGED up to date (similar to try_window_id) before the test in the following lines. If you say that is not necessary, it is ok with me to remove that code (but perhaps it would be better to just put #if 0 around it and add a comment which explains why it is not necessary). -- Kim F. Storm http://www.cua.dk