unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: spiegel@gnu.org, Emacs Hackers <emacs-devel@gnu.org>
Subject: Re: Patch to make VC annotate async
Date: Mon, 09 Jul 2007 09:12:00 -0600	[thread overview]
Message-ID: <m3sl7x7gsf.fsf@fleche.redhat.com> (raw)
In-Reply-To: <jwvvecwnd2z.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat\, 07 Jul 2007 17\:06\:57 -0400")

>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:

Stefan> For the vc-cvs.el part of the patch , can you try the patch below?

I haven't tried it yet, but I do have a question.

Stefan> +(defun vc-cvs-annotate-process-filter (process string)
Stefan> +  (setq string (concat (process-get process 'output) string))
Stefan> +  (if (not (string-match "^[0-9]" string))
Stefan> +      ;; Still waiting for the first real line.
Stefan> +      (process-put process 'output string)
Stefan> +    ;; FIXME: we shouldn't hardcode vc-process-filter here.
Stefan> +    (set-process-filter process 'vc-process-filter)
Stefan> +    (vc-process-filter process (substring string (match-beginning 0)))))

I had written a much more complicated filter because my reading of the
Elisp manual is that the output from the process won't necessarily
appear as full lines.  Is that not so?

Tom
o

  reply	other threads:[~2007-07-09 15:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-24  2:32 Patch to make VC annotate async Tom Tromey
2007-06-24 17:35 ` Richard Stallman
2007-06-24 18:05   ` Tom Tromey
2007-06-24 23:47     ` Richard Stallman
2007-06-24 19:33 ` Stefan Monnier
2007-06-24 21:32   ` Tom Tromey
2007-06-25  1:34     ` Stefan Monnier
2007-06-25 15:24       ` Tom Tromey
2007-06-25 16:54         ` Stefan Monnier
2007-06-25 17:53           ` Tom Tromey
2007-06-26 17:48       ` Stefan Monnier
2007-07-07 21:06 ` Stefan Monnier
2007-07-09 15:12   ` Tom Tromey [this message]
2007-07-09 19:09     ` David Kastrup
2007-07-11 16:02       ` Tom Tromey
2007-07-12  3:15         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3sl7x7gsf.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=spiegel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).