From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Buffer size limitation in insdel.c Date: Thu, 23 Sep 2010 15:37:35 +0200 Organization: Programmerer Ingebrigtsen Message-ID: References: <834odivv7v.fsf@gnu.org> <83r5gkvqpf.fsf@gnu.org> <83iq1wvep4.fsf@gnu.org> <83hbhgvblq.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1285249081 32635 80.91.229.12 (23 Sep 2010 13:38:01 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 23 Sep 2010 13:38:01 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 23 15:38:00 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Oylzp-00023W-L1 for ged-emacs-devel@m.gmane.org; Thu, 23 Sep 2010 15:37:57 +0200 Original-Received: from localhost ([127.0.0.1]:45130 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oylzp-0001GF-65 for ged-emacs-devel@m.gmane.org; Thu, 23 Sep 2010 09:37:57 -0400 Original-Received: from [140.186.70.92] (port=60971 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oylzh-0001GA-It for emacs-devel@gnu.org; Thu, 23 Sep 2010 09:37:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oylzc-0007Qh-LS for emacs-devel@gnu.org; Thu, 23 Sep 2010 09:37:49 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:50506) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oylzc-0007Qa-AX for emacs-devel@gnu.org; Thu, 23 Sep 2010 09:37:44 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Oylza-0001tG-Nt for emacs-devel@gnu.org; Thu, 23 Sep 2010 15:37:42 +0200 Original-Received: from cm-84.215.34.171.getinternet.no ([84.215.34.171]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 23 Sep 2010 15:37:42 +0200 Original-Received: from larsi by cm-84.215.34.171.getinternet.no with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 23 Sep 2010 15:37:42 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 38 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: cm-84.215.34.171.getinternet.no Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAKlBMVEVvCQ3AcU7ClWrWvJFj AAlMAAmGNBBJAAmBGxXj2dehUD1/Aw5GAAf8/PuUk3orAAACTElEQVQ4jZXRzWsaQRQA8LWHshh7 WCVQxD3UpVRFD6n0oLCHQttDk4OFUkrJIb2I4Obac22JNY2H1j2NMNDdg5hNhQj245BD86VGK4Sd g0xg/pe+2RU/EhU6u+yw89v33r4ZoROwglbP8tYLq4WaVfpULGvrof5qTrhglLEGaxCVMrgxu9LW 7xr3AUiY4gZOMAyrlMrE1rzxgzCAbTKWwCos8qHatnYroMciwgW8YRiIUAJ3AyI8ETtcF05QpRJF ++hhUv9adWusSGuPcsIpruinqIL0j/rul/zTI/FIWwn1H+SEAUnSAYF0MpMvXRBD/fgIbMqojNXL cQQHKA5AscrwTARvEPEmcQLTAwd+O9BL3VP4FVNMRQkK5ds7WtFNNfra5hNDwztsnxHC6tCgSTBP A13jaGq4jRPwOwCdBHGAcYjtDhs4jSsMYOBsiYqRM9ErlSGd8lSwJQh2JJpGiMIiYzJ1a/T0FKyv oWozkIol0z7xl/Y51IXz2Oa98dJNno5M+jiB35RZyqZwVlFKfBMgClZValO/qlaT0wARPBVxU02g Y5rBY8PyR5qmYoUjE2ib3mz3dfZZpqB5avknPvHHCF74/dKxJNUkPgzJL0lBF94YEofsWwecpwt/ P7QP+2cr7fOm9nwrn/GJO5Cqy6Ewhsff8i83nBrTcAawNQ/OF8FUxE+A/Ay8vwatEXhK/wllT2lv bg3fDWiNYX6qZREzYEygeAP+ONBcApkNsbUowoHQ/Ijvs7DJYVM8XA5wHsa7RfAKYO8axHP/AHpq VQN8S/cLAAAAAElFTkSuQmCC Mail-Copies-To: never X-Now-Playing: Various's _Crammed Global Soundclash 1980-89, Part One: World Fusion_: "Bel Canto - The Glassmaker" User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:sHa3NSlekXtsonrZ1lQplDQLK/w= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130663 Archived-At: Eli Zaretskii writes: >> dispnew.c:783: warning: conversion to 'int' from 'Lisp_Object' may alter its value >> >> matrix->window_left_col = WINDOW_LEFT_EDGE_COL (w); >> >> What's the right fix here? make window_left_col EMACS_INT, and slap an >> XINT around the WINDOW_LEFT_EDGE_COL? > > I don't see this warning with "gcc (GCC) 4.2.4 (Ubuntu 4.2.4-1ubuntu4)". This is with "gcc (Debian 4.4.4-7) 4.4.4". When I was Googling for -Wconversion, I found somebody saying that it's a switch that has existed for a long time, but it was recently given a total makeover, and was made to be more useful. > And I don't see how you could possibly get it, since > window_left_edge_col is an int, whereas WINDOW_LEFT_EDGE_COL is > defined like this: > > #define WINDOW_LEFT_EDGE_COL(W) \ > (XFASTINT ((W)->left_col)) > > So it already extracts the integer from a Lisp_Object. What am I > missing? Hm. What version of XFASTINT is being used by default? If it's this one, I can perhaps understand the warning. I think. #define XFASTINT(a) ((a) + 0) So gcc 4.4.4 doesn't understand that this converts from Lisp_Object a to EMACS_INT a? Which is what I'm assuming it's doing, although I'm not sure whether the C standard actually allows doing it this way? -- (domestic pets only, the antidote for overdose, milk.) larsi@gnus.org * Lars Magne Ingebrigtsen