From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: arc-mode Date: Sat, 18 May 2019 06:04:33 +0200 Message-ID: References: <83d0khb888.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="152546"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 18 06:05:00 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRqag-000dPa-1V for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 06:04:58 +0200 Original-Received: from localhost ([127.0.0.1]:57224 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRqae-0008Sn-FY for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 00:04:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRqaX-0008Se-Kq for emacs-devel@gnu.org; Sat, 18 May 2019 00:04:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRqaU-00074j-2M for emacs-devel@gnu.org; Sat, 18 May 2019 00:04:47 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:45910) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRqaQ-0006vO-5H; Sat, 18 May 2019 00:04:43 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hRqaH-00041x-NW; Sat, 18 May 2019 06:04:37 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEXmkRvfbAesPgL99sry rzH3zl1FEgDOGxF/AAACUUlEQVQ4jX2TsXbbMAxFwYTqTLDOXrInmtMi7EydULttkd6rnur/P6EP lBM7S7nY4iWIhweQYoxEw5HeV5lbK5lG/dtEUisFG2TwbUs/sa3Ozi3VgpWJsfq2pW1bA4JwCsD4 wMROrwFQQhz103hkVGBnBdsa47jhLBlIcdwldNBXBAEICCifwBqDXgWsKso9iM5wZAWlq3oH43rI ZNhZLYhuAGio2ME+ftwnMMMMVKuA78HvRVK2TWADeVo9argKXkReaV528A3+XEEASHAXjhpPh5on GNGByHkoILWYSAPEGWa9LrxJsWSRXsGMOl1mDYns8t4szYEGuLkav7tlUIDZAWxbBCB+AVAHM9v5 iDpC/AotMKluMa7aC6TQHn97kg54eVBADlViNDxBu0ibAE5xXJnf8FnRY5IOoOEtmTHwU8PJhqm4 RmTmx4RC0f0Zs3T8uKoaHuSo/WPkwLm4A+jlJ0jA9BwWzeG3GzjAQBMRCNvNuH6AeIDn2YcZFxf4 sIN08qvr3KmpBEtpz+0xwtqNzDCdENCvSk0nkDW2GGvpAQFdVW2GPXfwOjnS3qCg1rJrE3R2M6Qy 5hizhxeQxzCffLwCSCpVp5vsFMNQmX3YQRdZCroFm4aEPoZHuZGa8eKYrEyIuAOI0f5mKyfvw3AH 0AgkK1YSjH0UbYXsHgnkYsRETh2cz3/Of3+dHwAJfpQi8gKQXi6X7fL8c2wdJBCUHPfky5KSpLQA yNLmRX6s8V6uRqgPdISLV9DO358vyw5yHG/guhSkKcb/ATyyu/UP4P3eizSDL+EAAAAASUVORK5C YII= In-Reply-To: (Lars Ingebrigtsen's message of "Sat, 18 May 2019 05:56:04 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236687 Archived-At: Lars Ingebrigtsen writes: > Eli Zaretskii writes: > >> We have get-byte nowadays, so I believe the first defsubst is not >> needed. You just need to catch errors, maybe. For byte-after, I tried this: (defun byte-after (pos) "Like char-after but an eight-bit char is converted to unibyte." (cl-assert (= (multibyte-char-to-unibyte (char-after pos)) (get-byte pos))) (get-byte pos)) I then opened some archives (which will use byte-after all over the place), and I got no assertion errors. If you think it's OK, I can just replace all the calls to byte-after with get-byte in arc-mode.el and remove the defsubst. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no