From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Jan Nieuwenhuizen Newsgroups: gmane.emacs.devel Subject: Re: FIX#3: byte-code: Wrong type argument: number-or-marker-p, (+ -21) Date: Thu, 20 Nov 2003 10:59:40 +0100 Organization: Jan at Appel Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <200311142330.hAENUB5p021655@stubby.bodenonline.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1069323640 25281 80.91.224.253 (20 Nov 2003 10:20:40 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 20 Nov 2003 10:20:40 +0000 (UTC) Cc: "Jan D." , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu Nov 20 11:20:36 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AMlvQ-00060t-00 for ; Thu, 20 Nov 2003 11:20:36 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1AMlvQ-0002va-00 for ; Thu, 20 Nov 2003 11:20:36 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMmlJ-0007NS-HI for emacs-devel@quimby.gnus.org; Thu, 20 Nov 2003 06:14:13 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1AMmlB-0007NH-I7 for emacs-devel@gnu.org; Thu, 20 Nov 2003 06:14:05 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1AMmkf-0007Hy-Hv for emacs-devel@gnu.org; Thu, 20 Nov 2003 06:14:04 -0500 Original-Received: from [62.195.48.83] (helo=appel.flower) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AMmYq-0005Al-PI for emacs-devel@gnu.org; Thu, 20 Nov 2003 06:01:20 -0500 Original-Received: from localhost ([127.0.0.1] helo=appel.flower) by appel.flower with esmtp (Exim 3.36 #1 (Debian)) id 1AMlbA-0007TY-00; Thu, 20 Nov 2003 10:59:40 +0100 Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: (Kim F. Storm's message of "20 Nov 2003 00:46:25 +0100") User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3 (gnu/linux) X-RBL-Warning: (inputs.orbz.org) X-RBL-Warning: (outputs.orbz.org) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:17955 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:17955 storm@cua.dk (Kim F. Storm) writes: >> but I'm not at all sure about the right arithmetic for (+/- INT) ... > > Me neither... What do others think about this? So here's a patch #3 to try. Jan. 2003-11-20 Jan Nieuwenhuizen * frame.el (frame-notice-user-settings): Fix for TOP parameter of CONS flavour. --- frame.el.~1.205.~ 2003-10-02 16:06:45.000000000 +0200 +++ frame.el 2003-11-20 01:51:14.000000000 +0100 @@ -335,10 +335,18 @@ React to settings of `default-frame-alis frame-initial-geometry-arguments))) (top (frame-parameter frame-initial-frame 'top))) (when (and (consp initial-top) (eq '- (car initial-top))) - (setq newparms - (append newparms - `((top . ,(+ top (* lines char-height)))) - nil))) + (let ((new-top + (if (consp top) + (cond ((eq '+ (car top)) + (list + '+ (+ (cadr top) (* lines char-height)))) + ((eq '- (car top)) + (list + '- (- (display-pixel-height) + ((cadr top) (* lines char-height))))) + (t 0)) + (+ top (* lines char-height))))) + (setq newparms (append newparms `((top . ,new-top)) nil)))) (modify-frame-parameters frame-initial-frame newparms) (tool-bar-mode -1))))) -- Jan Nieuwenhuizen | GNU LilyPond - The music typesetter http://www.xs4all.nl/~jantien | http://www.lilypond.org