From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Problems with latest CVS. Date: 17 Feb 2004 02:37:29 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <200402162237.i1GMbYh08219@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1076978666 30463 80.91.224.253 (17 Feb 2004 00:44:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 17 Feb 2004 00:44:26 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Feb 17 01:44:16 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AstLU-00013N-00 for ; Tue, 17 Feb 2004 01:44:16 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1AstLU-0003pU-00 for ; Tue, 17 Feb 2004 01:44:16 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AstIu-0004Vz-UQ for emacs-devel@quimby.gnus.org; Mon, 16 Feb 2004 19:41:36 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1AstFj-0003ON-06 for emacs-devel@gnu.org; Mon, 16 Feb 2004 19:38:19 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1AstFB-0003Ap-8G for emacs-devel@gnu.org; Mon, 16 Feb 2004 19:38:16 -0500 Original-Received: from [195.41.46.235] (helo=pfepa.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AstFA-00039r-Ip for emacs-devel@gnu.org; Mon, 16 Feb 2004 19:37:44 -0500 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk [80.62.38.68]) by pfepa.post.tele.dk (Postfix) with SMTP id 31EA447FF6C; Tue, 17 Feb 2004 01:37:37 +0100 (CET) Original-To: Luc Teirlinck In-Reply-To: <200402162237.i1GMbYh08219@raven.dms.auburn.edu> Original-Lines: 30 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:20004 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20004 Luc Teirlinck writes: > Does anybody else see any of this? > > With the very latest CVS Emacs used to crash rather quickly after > startup after typing a bunch of keystrokes. After reverting this > change: > > 2004-02-16 Dmitry Antipov (tiny change) > > * keyboard.c (prev_read): New static variable. > (read_avail_input): Use it to zero out only those slots in > buf[] > that were used last time we were called. > > Emacs no longer seems to crash. It was using uninitialized data on the stack. I have installed a (hopefully) correct fix for this, preserving the intention of only clearing what's being used. BTW, I also installed another fix a hour ago or so, but it wasn't ok, as it caused emacs to loop in GC. My latest fix (properly handling re-entrance to read_avail_input) seems to work alright. If there are still problems, I suggest to revert keyboard.c back to revision 1.761.