From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Several suggestions for image support Date: 26 Apr 2004 11:38:26 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <200404230033.JAA10583@etlken.m17n.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1082966120 13447 80.91.224.253 (26 Apr 2004 07:55:20 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 26 Apr 2004 07:55:20 +0000 (UTC) Cc: emacs-devel@gnu.org, rms@gnu.org, Kenichi Handa Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Apr 26 09:55:07 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BI0xH-00080l-00 for ; Mon, 26 Apr 2004 09:55:07 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BI0xG-0004ju-00 for ; Mon, 26 Apr 2004 09:55:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BI0rU-0004eH-H5 for emacs-devel@quimby.gnus.org; Mon, 26 Apr 2004 03:49:08 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BI0rP-0004de-0y for emacs-devel@gnu.org; Mon, 26 Apr 2004 03:49:03 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BI0qs-0004WU-75 for emacs-devel@gnu.org; Mon, 26 Apr 2004 03:49:02 -0400 Original-Received: from [212.88.64.25] (helo=mail-relay.sonofon.dk) by monty-python.gnu.org with smtp (Exim 4.30) id 1BI0nt-0003J2-2E for emacs-devel@gnu.org; Mon, 26 Apr 2004 03:45:25 -0400 Original-Received: (qmail 673 invoked from network); 26 Apr 2004 07:38:42 -0000 Original-Received: from unknown (HELO kfs-l.imdomain.dk.cua.dk) (213.83.150.2) by 0 with SMTP; 26 Apr 2004 07:38:42 -0000 Original-To: David Kastrup In-Reply-To: Original-Lines: 50 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:22155 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:22155 David Kastrup writes: > storm@cua.dk (Kim F. Storm) writes: > > > I have now reworked my line height changes. > > > > Now, the height of a newline equals the current face height, unless an > > explicit line-spacing property is present on the newline character. > > > > If the value of the line-spacing property is t, you get the effect of > > my previous change, i.e. the newline character does not add to the > > height of the row by itself, but the newline glyph is re-positioned > > inside the available row height to make it fully visible (when the > > cursor is above it). > > > > If the value is an integer, it overrides the value of the frame > > line-spacing parameter and the (buffer local) value of the line-spacing > > variable. > > So presumably setting the value to 0 will make the newline have the > height of a normal space in the line? With the current code, it will have the height of a space in the current face, not the default face. Maybe the functionality should be that newlines are by default always in the default face height, and the line-spacing property should not change that. Instead, it would be better to have a separate line-height property which can have values: nil -> use default face height (as minimum height) t -> use height of current face 0 -> use actual line height N (integer > 0) -> use N pixels (as minimum height) F (float > 0.0) -> use F * default face height I think that would be a much cleaner interface. > > One thing that one should try is to have no surprising changes if the > newline is turned into a space while keeping its properties: > re-filling a paragraph will do that. You can just put the line-spacing (or line-height) property on the whole paragraph and make it sticky. -- Kim F. Storm http://www.cua.dk