From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: storm@cua.dk (Kim F. Storm)
Newsgroups: gmane.emacs.devel
Subject: Re: Preventing stack overflows with alloca.
Date: 20 Jun 2004 20:56:24 +0200
Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Message-ID: <m3pt7ucb3b.fsf@kfs-l.imdomain.dk>
References: <m3smctxje6.fsf@kfs-l.imdomain.dk>
	<200406181113.UAA03743@etlken.m17n.org>
	<m3k6y5xefb.fsf@kfs-l.imdomain.dk>
	<E1BbWNv-0001Eh-Ms@fencepost.gnu.org>
NNTP-Posting-Host: deer.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: sea.gmane.org 1087757808 18633 80.91.224.253 (20 Jun 2004 18:56:48 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Sun, 20 Jun 2004 18:56:48 +0000 (UTC)
Cc: emacs-devel@gnu.org, handa@m17n.org
Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sun Jun 20 20:56:39 2004
Return-path: <emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1Bc7Ud-0004hG-00
	for <emacs-devel@deer.gmane.org>; Sun, 20 Jun 2004 20:56:39 +0200
Original-Received: from lists.gnu.org ([199.232.76.165])
	by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian))
	id 1Bc7Ud-0002ip-00
	for <emacs-devel@quimby.gnus.org>; Sun, 20 Jun 2004 20:56:39 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33)
	id 1Bc7Vq-00073J-8j
	for emacs-devel@quimby.gnus.org; Sun, 20 Jun 2004 14:57:54 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1Bc7Vn-000734-TX
	for emacs-devel@gnu.org; Sun, 20 Jun 2004 14:57:51 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1Bc7Vm-00072s-FY
	for emacs-devel@gnu.org; Sun, 20 Jun 2004 14:57:51 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1Bc7Vm-00072p-CR
	for emacs-devel@gnu.org; Sun, 20 Jun 2004 14:57:50 -0400
Original-Received: from [195.41.46.236] (helo=pfepb.post.tele.dk)
	by monty-python.gnu.org with esmtp (Exim 4.34)
	id 1Bc7U4-00019p-A7; Sun, 20 Jun 2004 14:56:04 -0400
Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk
	[80.62.38.68])
	by pfepb.post.tele.dk (Postfix) with SMTP id 691175EE00B;
	Sun, 20 Jun 2004 20:56:02 +0200 (CEST)
Original-To: rms@gnu.org
In-Reply-To: <E1BbWNv-0001Eh-Ms@fencepost.gnu.org>
Original-Lines: 17
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:25124
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25124

Richard Stallman <rms@gnu.org> writes:

>     Since old_value is not a lisp object here,
>     we would need to fix (hack) GC like this:
> 
>       for (bind = specpdl; bind != specpdl_ptr; bind++)
> 	{
> 	  mark_object (bind->symbol);
> 	  if (bind->func != safe_alloca_unwind)
> 	    mark_object (bind->old_value);
> 	}
> 
> Or else use make_save_value to convert it to a clean Lisp object.
> Then GC won't need changing.

I had forgot about make_save_value.  Yes, we should use that.