Editing keyboard macros

Editing keyboard macros

[Jay Belanger]

When a keyboard macro is edited, it is assumed that the macro is an
array.  However, `kmacro-name-last-macro' and 'kmacro-bind-to-key' now
put the macro in a lambda expression, and so `edit-kbd-macro' gives an
error if you try to edit a named macro.  Should the naming of macros
be reverted to storing them as arrays?  
(`edit-kbd-macro' could be partially rewritten, I suppose, but that
would be more work.  I assume that the named keyboard macros are
stored as lambda expressions so they can be called from lisp (which
would make the docstrings out of date).  But the ability to edit a
keyboard macro seems like too much to lose.)

Jay

Re: Editing keyboard macros

[Kim F. Storm]

Jay Belanger <belanger@truman.edu> writes:

> When a keyboard macro is edited, it is assumed that the macro is an
> array.  However, `kmacro-name-last-macro' and 'kmacro-bind-to-key' now
> put the macro in a lambda expression, and so `edit-kbd-macro' gives an
> error if you try to edit a named macro.  Should the naming of macros
> be reverted to storing them as arrays?  

There are good reasons for the change to lambda forms (to handle
per-macro counter and counter format), so that is not an option.

> (`edit-kbd-macro' could be partially rewritten, I suppose, but that
> would be more work.  I assume that the named keyboard macros are
> stored as lambda expressions so they can be called from lisp (which
> would make the docstrings out of date).  But the ability to edit a
> keyboard macro seems like too much to lose.)

I will fix edit-kbd-macro to handle kmacro generated lambda forms.

Thanks for reporting the problem.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Editing keyboard macros

[Kim F. Storm]

storm@cua.dk (Kim F. Storm) writes:

> I will fix edit-kbd-macro to handle kmacro generated lambda forms.

I have installed changes to handle this.  Please try them.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Editing keyboard macros

[Jay Belanger]

storm@cua.dk (Kim F. Storm) writes:

> storm@cua.dk (Kim F. Storm) writes:
>
>> I will fix edit-kbd-macro to handle kmacro generated lambda forms.
>
> I have installed changes to handle this.  Please try them.

Works great, thanks.
It doesn't work on keyboard macros that Calc saves, but that's a
problem with Calc that needs to be fixed.

Jay

Re: Editing keyboard macros

[Kim F. Storm]

Jay Belanger <belanger@truman.edu> writes:

> It doesn't work on keyboard macros that Calc saves, but that's a
> problem with Calc that needs to be fixed.

What's special about them ?
Can you show me an example ?

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Editing keyboard macros

[Jay Belanger]

>> It doesn't work on keyboard macros that Calc saves, but that's a
>> problem with Calc that needs to be fixed.
>
> What's special about them ?
> Can you show me an example ?

Mostly, I think, it uses `calc-execute-kbd-macro' instead of
`kmacro-exec-ring-item'.  There are other differences, the two macros
at the end of this message both enter "45 RET S".  
Calc keyboard macros are created in the usual way, but Calc saves it's
macros differently because using a kmacro saved macro in Calc will put
each part of it on the Calc trail and in the undo stack, using a Calc
saved keyboard macro will only put one item in the trail and stack.
(Calc does other things different, too.  When it attaches a macro to a
key, it makes it local to Calc.)
I'm thinking it might make sense to modify macedit.el, which came with
older versions of Calc, to create a special Calc keyboard macro
editing function.  macedit.el wasn't made part of Emacs when Calc was,
but it was written by Dave Gillespie.  Can anyone say if the copyright
papers he signed would also cover macedit.el?

Jay

(defun calc-User-g (&optional arg) 
 "Keyboard macro." 
 (interactive "p") 
 (kmacro-exec-ring-item (quote ([52 53 return 83] 0 "%d")) arg))

(defun calc-User-h (arg) 
  (interactive "P") 
  (calc-execute-kbd-macro ["4 5 <return> S" [52 53 return 83]] arg "zh"))

Re: Editing keyboard macros

[Kim F. Storm]

Jay Belanger <belanger@truman.edu> writes:

>>> It doesn't work on keyboard macros that Calc saves, but that's a
>>> problem with Calc that needs to be fixed.
>>
>> What's special about them ?
>> Can you show me an example ?
>
> Mostly, I think, it uses `calc-execute-kbd-macro' instead of
> `kmacro-exec-ring-item'.  There are other differences, the two macros
> at the end of this message both enter "45 RET S".  

I guess this could be handled by edmacro quite similar to the way I
handle kmacro macros.

I'll put it on my to-do list.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk