unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Sam Steingold <sds@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: crash in the cvs head build of Feb 13 08:40
Date: Sun, 19 Feb 2006 17:33:23 -0500	[thread overview]
Message-ID: <m3pslj9dxo.fsf@loiso.podval.org> (raw)
In-Reply-To: <E1FAscx-0006Nc-LI@fencepost.gnu.org> (Richard M. Stallman's message of "Sun, 19 Feb 2006 12:45:43 -0500")

> * Richard M. Stallman <ezf@tah.bet> [2006-02-19 12:45:43 -0500]:
>
> In this case I think it is better to be less defensive
> and stick more clearly to the rules from which the code was written.
> Does this patch fix the bug?

I cannot reproduce the bug (with or without the patch).

> *** xmenu.c	07 Feb 2006 18:13:41 -0500	1.299
> --- xmenu.c	19 Feb 2006 11:46:11 -0500	
> ***************
> *** 1807,1814 ****
>   	      wv->enabled = 1;
>   	      wv->button_type = BUTTON_TYPE_NONE;
>   	      wv->help = Qnil;
>   	    }
> ! 	  save_wv = wv;
>   	  prev_wv = 0;
>   	  i += MENU_ITEMS_PANE_LENGTH;
>   	}
> --- 1807,1817 ----
>   	      wv->enabled = 1;
>   	      wv->button_type = BUTTON_TYPE_NONE;
>   	      wv->help = Qnil;
> + 	      save_wv = wv;
>   	    }
> ! 	  else
> ! 	    save_wv = first_wv;
> ! 
>   	  prev_wv = 0;
>   	  i += MENU_ITEMS_PANE_LENGTH;
>   	}

-- 
Sam Steingold (http://www.podval.org/~sds) running FC3 GNU/Linux
http://truepeace.org http://www.dhimmi.com http://www.jihadwatch.org
http://www.iris.org.il http://www.camera.org http://pmw.org.il http://ffii.org
The software said it requires Windows 3.1 or better, so I installed Linux.

      reply	other threads:[~2006-02-19 22:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-15 13:49 crash in the cvs head build of Feb 13 08:40 Sam Steingold
2006-02-17 13:36 ` Kim F. Storm
2006-02-19 17:45 ` Richard M. Stallman
2006-02-19 22:33   ` Sam Steingold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3pslj9dxo.fsf@loiso.podval.org \
    --to=sds@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).