From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Patches for qop=auth implementation for url-digest-auth Date: Mon, 18 May 2015 17:47:59 +0200 Message-ID: References: <1431371843-4502-1-git-send-email-jarno@malmari.fi> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1431964150 1584 80.91.229.3 (18 May 2015 15:49:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 May 2015 15:49:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jarno Malmari Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 18 17:49:00 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YuNHg-0000o1-Sz for ged-emacs-devel@m.gmane.org; Mon, 18 May 2015 17:48:53 +0200 Original-Received: from localhost ([::1]:41634 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuNHg-00035Z-E8 for ged-emacs-devel@m.gmane.org; Mon, 18 May 2015 11:48:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuNHL-00032o-H3 for emacs-devel@gnu.org; Mon, 18 May 2015 11:48:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YuNHH-0006fe-3G for emacs-devel@gnu.org; Mon, 18 May 2015 11:48:31 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:36872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YuNHG-0006cc-TL for emacs-devel@gnu.org; Mon, 18 May 2015 11:48:27 -0400 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1YuNGq-0006zO-7U; Mon, 18 May 2015 17:48:00 +0200 X-Hashcash: 1:23:150518:emacs-devel@gnu.org::9cKgxkURlXIPb0hj:0000000000000000000000000000000000000000005CZp X-Hashcash: 1:23:150518:jarno@malmari.fi::u9mtQGfZJu0Rn3x3:0aN2J In-Reply-To: <1431371843-4502-1-git-send-email-jarno@malmari.fi> (Jarno Malmari's message of "Mon, 11 May 2015 22:17:20 +0300") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) X-MailScanner-ID: 1YuNGq-0006zO-7U MailScanner-NULL-Check: 1432568880.32095@3kjPfUhD4UISrD1gSTDnOw X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:186581 Archived-At: Jarno Malmari writes: > I am not sure how common it is to have no backward compatibility for > qop-less clients, as that is, afaik, against the standard RFC 2617. My > use case and motivation for testing this is based on Gerrit servers > that gave Forbidden with the old qop-less implementation, and with > these patches, I can authenticate successfully. I'm not familiar with the digest authentication stuff at all, but surely having support for qop is better than not having support for qop. :-) The code looks fine to me. Do you have FSF copyright assignment papers on file? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no