From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: eieio Date: Fri, 14 Jun 2019 14:11:09 +0200 Message-ID: References: <83a7eo9nsh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="256235"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 14 14:12:21 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbl48-0014Vw-Pd for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 14:12:20 +0200 Original-Received: from localhost ([::1]:50802 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbl47-0004Iv-DP for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 08:12:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52242) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbl3E-0003p7-1J for emacs-devel@gnu.org; Fri, 14 Jun 2019 08:11:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbl3B-0004Xs-Mq for emacs-devel@gnu.org; Fri, 14 Jun 2019 08:11:23 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:40962) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbl3B-0004Sc-Fc for emacs-devel@gnu.org; Fri, 14 Jun 2019 08:11:21 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbl2z-0002nq-UY; Fri, 14 Jun 2019 14:11:12 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUREBS9v74oJytTU1dz dHY7Oz9EDn//AAACYElEQVQ4jXWU3Y6jMAyFI2gfoBJzz4T6vsXxfSHJPXXw+7/KHtPOjka74woJ 5YuPf2m4/GKhlOU/xwUgA3yxjzIsS+blBcrw9+IA/yL5BWA/VHIqJQEMP48hb7IzwKUMX1IDFBb8 IDE48BjLK0BOKXE6Eg3fGoNHQ/DyBsPyDZbLRxLmfwHEC7Okn1LllfmXFHI+jLO/cUqFG557MBPh GOO4Pe7VtLd1DGT6GVgyzziPpiVa69YHgOgTgEUBqJ/WKe9bXTcAA2A2V5qm60zF1n2CR5NnMDYC iJOk0LKW6wRvZgCDEEWjR+1L0WdrFFvK96B+X2PT+bGnUk9rFWoFwGUIQGyse026zpWSA1WFGDWe zrrn6cZtFYBnEDI4mDD1HdKop2vj8gYQa9LG2JGO7ZSQX0FWXpwr2TZ2aluv1XuFOsYQOjJmxQup duuaLWX5DLAIIBsulEqj2Nwazy9gUNIQTrlFnXZTYXXQRThEKPHYRZomUhR1DfEIYR5qxnOOuGQH IJi5Qz/SGKJUMWuYhxoZKoEkdSV7YwHE9sAY7eEQbtchzaihOMCgrMoROmyLErdSasPsfB6MmeP8 TBVyWKCMlROP0Zp6df3pRkoJ3wGjwnuQOLUjWdq7pTgoiH4A9N2V5nodSk2XIXtaABYtevnzWqCE 7c0G870y71NUpNdh2lhTHxA2Ef0zzIj309ZFX2TxNbhCynyDKLW9O74mVlcGIAUw2+e1F4z7GABG ECCIZhmW42aYcGoS38C33gi7HWf0u9V5fAEZQwfQZDrDNZnoG+QDQIsIoNVGb/Db39IfiP7LaOyY phsAAAAASUVORK5CYII= In-Reply-To: (Stefan Monnier's message of "Thu, 13 Jun 2019 12:13:07 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237596 Archived-At: Stefan Monnier writes: >> (cl-defmethod cl-print-object ((object eieio-default-superclass) stream) >> "Default printer for EIEIO objects." >> ;; Fallback to the old `object-print'. >> (princ (object-print object) stream)) > > This is backward compatibility for those packages that define an > `object-print` method on their own eieio classes (instead of a method > on cl-print-object). Yes, but what I wandered was about the call to `object-print'. It seems like the definition of object-print here is kinda trivial: (cl-defmethod object-print ((this eieio-default-superclass) &rest strings) [...] (eieio-object-name this (apply #'concat strings))) So couldn't cl-print-object just say (eieio-object-name object) instead of (object-print object) in the body and avoid the compilation warning? Or am I misreading the code? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no