From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: cedet Date: Fri, 14 Jun 2019 16:10:14 +0200 Message-ID: References: <83a7eo9nsh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="269632"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 14 16:54:10 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbnak-00181i-Hk for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 16:54:10 +0200 Original-Received: from localhost ([::1]:52314 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbnaj-000374-Fa for ged-emacs-devel@m.gmane.org; Fri, 14 Jun 2019 10:54:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56284) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbmuT-0000lG-I2 for emacs-devel@gnu.org; Fri, 14 Jun 2019 10:10:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbmuI-0004JE-JQ for emacs-devel@gnu.org; Fri, 14 Jun 2019 10:10:22 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:42960) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbmuI-0004I6-As for emacs-devel@gnu.org; Fri, 14 Jun 2019 10:10:18 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbmuE-0003pC-OE; Fri, 14 Jun 2019 16:10:17 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEWo+wir/wBIeQF+1gCq /wCK3wh80wB60gCoFct+AAACIUlEQVQ4jW2TT5eaMBTFo4N12/TwAZynlq3TCGvgxHELkhy3rbRh O6UCX7/v5Y/j2N7l+3HfvYmRyX9UxLwoYiasGo1SUnKcc1LMusmpFQKBjD3gAYwe8KAAjLCgiONH EBzyAYyZz7it8gZatbdlHx24a383D6CbTOYcXh50hmoRyAXTQzYpzsxI0240LjxPtRjOFkwjZk+j d8iD1o2En5xlo6GIydZd+AT4zZkwVKlzjiaicb4/F+gwNv22CjVPZlg3c63uQZ/XnMLpeJ1x4AwI LkMRHFNotcoRnK78tspeL4JNheD49gFYh6JaJxve0fgG6CAHAEnhHVUKoLxKuYSvBITBRsZ0rQUN KAmwlTMLRiLWcVoDXCdYf3pBkNmxGRHkgBIAybcNObyw7oHAEmDqCbQe0CoCMkGi3KrOuMdgV2EB SCKfkbWCWpXfEUSvyTHZI0BCT4QcZdoDqGMywCa0Eg5UJYAuIeoDyBzI8zmeo4Tru8OtktUJYD8H 9QCU7C89zC7wZh9DFuZCzTdbmRSreTI825O3PlwN281syVcHUM/+SlI6hnhJoFZfiiTqJYEWd2nr qNdQTK+8V/nCAmHEkwN4H1DzUyH1DwQ7JtIn7cFQrvj5V5xTq7QSu4YFcN5+fmNM1taxq4RzJKBZ xVD0ShDohXCOqp9XixtIWeOyRT2DP1Nnf0Z6cO7UFvCcPmYR/deZflfN78R0xAv+H/0FHewebQnN mwMAAAAASUVORK5CYII= In-Reply-To: (Stefan Monnier's message of "Fri, 14 Jun 2019 09:54:01 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237616 Archived-At: Stefan Monnier writes: >> I'll go through all the warnings emitted and adjust the >> oref/oset/slot-value calls and push after I've figured out how to >> actually test this stuff. I mean, it looks like it should be a >> semi-mechanical replacement situation, but I hate not testing these >> things... > > The non-mechanical part is to look for the :initarg to see if > indeed : is the init arg for the slot. > This is *usually* the case, but it's just a coding convention, I grepped through :initarg in cedet, and it looks like there's only one: (max-tags-initial :initarg max-tags-initial And my changes didn't change any of the call sites... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no