unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Benjamin Riefenstahl <Benjamin.Riefenstahl@epost.de>
Cc: emacs-devel@gnu.org
Subject: Re: Status of MAC/W32/X consolidation -- first major patch committed.
Date: 17 Mar 2003 15:56:01 +0100	[thread overview]
Message-ID: <m3of4arqim.fsf@cicero.benny.turtle-trading.net> (raw)
In-Reply-To: <5xbs0bq8en.fsf_-_@kfs2.cua.dk>

Hi Kim,


no-spam@cua.dk (Kim F. Storm) writes:
> I have only been able to test this on X (under GNU/Linux), so there
> may be some problems compiling (and running) the consolidated code on
> W32 and MAC.  Please report any problems to me (unless you can fix
> them yourself).

On MacOSX I had to do this small patch:

<<<<
diff -c -p -r1.811 xdisp.c
*** src/xdisp.c	16 Mar 2003 20:45:46 -0000	1.811
--- src/xdisp.c	17 Mar 2003 14:31:51 -0000
*************** x_produce_glyphs (it)
*** 17475,17481 ****
  	      if (font == NULL)
  		{
  		  font = FRAME_FONT (it->f);
! 		  boff = it->f->output_data.x->baseline_offset;
  		  font_info = NULL;
  		}
  	      else
--- 17475,17481 ----
  	      if (font == NULL)
  		{
  		  font = FRAME_FONT (it->f);
! 		  boff = FRAME_BASELINE_OFFSET(it->f);
  		  font_info = NULL;
  		}
  	      else
>>>>

Note that FRAME_BASELINE_OFFSET() refers to the same variable "int
baseline_offset" in the different system-specific structs and the
variable is always accessed through the macro.  So it may properly
belong into the common data structure struct frame instead anyway.


so long, benny

  parent reply	other threads:[~2003-03-17 14:56 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-10 12:13 Status of MAC/W32/X consolidation and some questions Kim F. Storm
2003-03-10 17:00 ` Andrew Choi
2003-03-11  1:06   ` Kim F. Storm
2003-03-11 15:31     ` Andrew Choi
2003-03-10 17:09 ` Andrew Choi
2003-03-11  1:04   ` Kim F. Storm
2003-03-11 15:40     ` Andrew Choi
2003-03-10 17:23 ` Benjamin Riefenstahl
2003-03-11  1:01   ` Kim F. Storm
2003-03-11  0:19     ` Juanma Barranquero
2003-03-11 10:35       ` Kim F. Storm
2003-03-11 10:07     ` Jason Rumney
2003-03-11 11:09       ` Kim F. Storm
2003-03-12  4:47       ` Miles Bader
2003-03-11  0:03 ` Jason Rumney
2003-03-11  1:47 ` Miles Bader
2003-03-11 19:03   ` Stefan Monnier
2003-03-12  4:44     ` Miles Bader
2004-07-22 15:11   ` Kim F. Storm
2004-07-22 21:40     ` Miles Bader
2003-03-11 14:19 ` Kim F. Storm
2003-03-12 19:27   ` Eli Zaretskii
2003-03-12 23:01     ` Kim F. Storm
2003-03-16 22:00   ` Status of MAC/W32/X consolidation -- first major patch committed Kim F. Storm
2003-03-16 22:27     ` Jason Rumney
2003-03-16 23:59       ` Kim F. Storm
2003-03-17  8:56         ` Jason Rumney
2003-03-17 11:40           ` Kim F. Storm
2003-03-17 14:56     ` Benjamin Riefenstahl [this message]
     [not found]       ` <1047913554.3e75e4529bc88@webmail.freedom2surf.net>
2003-03-17 16:43         ` Benjamin Riefenstahl
2003-03-17 19:01       ` Juanma Barranquero
2003-03-21 15:10     ` Status of MAC/W32/X consolidation -- second " Kim F. Storm
2003-03-21 16:46       ` Juanma Barranquero
2003-03-21 22:48         ` Kim F. Storm
2003-03-24 20:07       ` Andrew Choi
2003-03-31 22:16       ` Status of MAC/W32/X consolidation -- third " Kim F. Storm
2003-04-01  1:13         ` Andrew Choi
2003-04-01  9:27           ` Kim F. Storm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3of4arqim.fsf@cicero.benny.turtle-trading.net \
    --to=benjamin.riefenstahl@epost.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).