From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master f2da80d: Ignore invalid base64 encoded embedded images
Date: Sun, 20 Mar 2016 16:40:39 +0100 [thread overview]
Message-ID: <m3oaa9uphk.fsf@gnus.org> (raw)
In-Reply-To: <jwvh9g1yxxp.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Sun, 20 Mar 2016 11:26:56 -0400")
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
> Hmm... I guess if payload is not a string at all because download
> failed, then indeed we have other indications of the problem and
> emitting a message would be redundant (and it's a normal occurrence
> anyway), but is it really "normal business" for payload to be
> a non-base64 string? I thought this would indicate some really
> unexpected circumstance.
The test case (encountered in the wild) was a base64 string, but it was
invalid.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-03-20 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160320125720.21872.87876@vcs.savannah.gnu.org>
[not found] ` <E1ahcv2-0005hP-Mn@vcs.savannah.gnu.org>
2016-03-20 13:47 ` [Emacs-diffs] master f2da80d: Ignore invalid base64 encoded embedded images Stefan Monnier
2016-03-20 13:49 ` Lars Magne Ingebrigtsen
2016-03-20 15:26 ` Stefan Monnier
2016-03-20 15:40 ` Lars Magne Ingebrigtsen [this message]
2016-03-20 16:12 ` Stefan Monnier
2016-03-20 16:41 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3oaa9uphk.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).