* Re: [Emacs-diffs] master 573de39 2/3: Apply font-lock in hexl-mode buffers
[not found] ` <20190627115607.CFCBB209C7@vcs0.savannah.gnu.org>
@ 2019-06-27 13:08 ` Stefan Monnier
2019-06-27 14:27 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2019-06-27 13:08 UTC (permalink / raw)
To: Lars Ingebrigtsen, Wilfred Hughes; +Cc: emacs-devel
> * lisp/hexl.el (hexl-mode): After setting font-lock-defaults, we
> need to call `font-lock-ensure' to apply hexl-mode faces
> (bug#24645).
I looked at the bug report but couldn't figure out what problem this
is fixing. AFAICT, when I do `M-x hexl-mode` the result is properly
fontified even without this patch.
> (if hexl-follow-ascii (hexl-follow-ascii-mode 1)))
> + (when global-font-lock-mode
> + (font-lock-ensure))
> (run-mode-hooks 'hexl-mode-hook))
In a large buffer, this can take a lot of time (it defeats jit-lock-mode).
Also I'm not sure just testing global-font-lock-mode is right here: if we go
this route, we should also obey font-lock-global-modes.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] master 573de39 2/3: Apply font-lock in hexl-mode buffers
2019-06-27 13:08 ` [Emacs-diffs] master 573de39 2/3: Apply font-lock in hexl-mode buffers Stefan Monnier
@ 2019-06-27 14:27 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2019-06-27 14:27 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Wilfred Hughes, emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> * lisp/hexl.el (hexl-mode): After setting font-lock-defaults, we
>> need to call `font-lock-ensure' to apply hexl-mode faces
>> (bug#24645).
>
> I looked at the bug report but couldn't figure out what problem this
> is fixing. AFAICT, when I do `M-x hexl-mode` the result is properly
> fontified even without this patch.
Oh, I thought I tested that, but apparently not. I'll revert it...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-27 14:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190627115605.31129.74412@vcs0.savannah.gnu.org>
[not found] ` <20190627115607.CFCBB209C7@vcs0.savannah.gnu.org>
2019-06-27 13:08 ` [Emacs-diffs] master 573de39 2/3: Apply font-lock in hexl-mode buffers Stefan Monnier
2019-06-27 14:27 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).