From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: Alexander Adolf <alexander.adolf@condition-alpha.com>
Cc: Jean-Christophe Helary
<jean.christophe.helary@traduction-libre.org>,
emacs-devel@gnu.org
Subject: Re: [Proposal] New EUDC backend for macOS address book
Date: Wed, 06 May 2020 13:41:11 -0400 [thread overview]
Message-ID: <m3o8r1j70o.fsf@fitzsim.org> (raw)
In-Reply-To: <8da7df5281e91d8a351f97c0837d79b7@condition-alpha.com> (Alexander Adolf's message of "Wed, 06 May 2020 17:14:59 +0200")
Hi Alexander,
Alexander Adolf <alexander.adolf@condition-alpha.com> writes:
[...]
> Therefore, we can simply use `tell application "Address Book"`, and it
> will work on all 10.x macOS-es.
OK, that's nice.
[...]
> I have also folded the lengthy error message line to be below the 80
> limit. Not sure whether this would be considered good practice?
Yes, looks good. I noticed one more formatting thing. font-lock is
showing "result))))" in red; you can type C-h . to check what the
warning is, which in this case is "Hidden behind deeper element; move to
another line?". Can you put that on its own line to eliminate the
warning?
>> Would you be able to write a section in the EUDC manual describing the
>> backend and how it relates to eudcb-mab.el?
>>
>> I don't think it hurts to offer both backends, provided they're
>> documented and contrasted in the EUDC manual.
>
> Yes, I'll be happy to write up a text for the manual.
OK, sounds good.
[...]
> Thanks for these improvements. All applied in the attached, updated
> version; except for the last one, which I solved differently.
This looks good to go in now. Can you send a draft of the manual
change, and then once that's reviewed, I'll have you put it all into one
git-format-patch attachment (including the commit log/change log entry)
and I can push that to master?
Thanks,
Thomas
next prev parent reply other threads:[~2020-05-06 17:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 15:09 [Proposal] New EUDC backend for macOS address book Alexander Adolf
2020-04-27 16:10 ` Thomas Fitzsimmons
2020-04-27 16:41 ` Jean-Christophe Helary
2020-05-02 16:20 ` Thomas Fitzsimmons
2020-05-06 15:14 ` Alexander Adolf
2020-05-06 17:41 ` Thomas Fitzsimmons [this message]
2020-05-07 16:03 ` Alexander Adolf
2020-05-07 18:29 ` Thomas Fitzsimmons
2020-05-08 12:17 ` Alexander Adolf
2020-05-08 13:44 ` Thomas Fitzsimmons
2020-06-08 20:41 ` Alexander Adolf
2020-06-10 5:03 ` Thomas Fitzsimmons
2020-06-29 13:38 ` Alexander Adolf
2020-07-09 15:12 ` Alexander Adolf
2020-07-09 20:29 ` Thomas Fitzsimmons
2020-07-10 13:36 ` Alexander Adolf
2020-07-10 3:53 ` Richard Stallman
2020-07-14 14:46 ` Thomas Fitzsimmons
2020-07-15 3:49 ` Jean-Christophe Helary
2020-07-17 0:56 ` Richard Stallman
2020-08-09 1:57 ` Richard Stallman
2020-09-06 3:00 ` Thomas Fitzsimmons
2020-05-05 14:47 ` Alexander Adolf
2020-04-27 20:00 ` chad
2020-05-05 13:30 ` Alexander Adolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3o8r1j70o.fsf@fitzsim.org \
--to=fitzsim@fitzsim.org \
--cc=alexander.adolf@condition-alpha.com \
--cc=emacs-devel@gnu.org \
--cc=jean.christophe.helary@traduction-libre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).