From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: QNX subprocess bug Date: Wed, 05 Apr 2006 11:01:14 +0200 Message-ID: References: <200604031800.k33I0DAv002355@copenhagen.cuug.ab.ca> <878xqlhs8m.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1144227820 27455 80.91.229.2 (5 Apr 2006 09:03:40 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 5 Apr 2006 09:03:40 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 05 11:03:37 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FR3vF-0002pp-Ox for ged-emacs-devel@m.gmane.org; Wed, 05 Apr 2006 11:03:29 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FR3vF-0002fx-Ck for ged-emacs-devel@m.gmane.org; Wed, 05 Apr 2006 05:03:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FR3v2-0002eS-6W for emacs-devel@gnu.org; Wed, 05 Apr 2006 05:03:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FR3v0-0002eF-JW for emacs-devel@gnu.org; Wed, 05 Apr 2006 05:03:15 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FR3v0-0002eC-Fz for emacs-devel@gnu.org; Wed, 05 Apr 2006 05:03:14 -0400 Original-Received: from [195.41.46.235] (helo=pfepa.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FR3yT-0003kp-9E; Wed, 05 Apr 2006 05:06:49 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepa.post.tele.dk (Postfix) with SMTP id 79413FAC06B; Wed, 5 Apr 2006 11:03:09 +0200 (CEST) Original-To: Stefan Monnier In-Reply-To: <878xqlhs8m.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 04 Apr 2006 18:55:34 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52433 Archived-At: Stefan Monnier writes: > I think the best solution is to keep pid_t values (without changing them > into Lisp_Object values) as long as possible, and to use floats when turning > them into Lisp_Object. Thanks Stefan. This is a change that I have wanted to make for a very long time! However, I would change the following not-really-Lisp_Object fields as well: unsigned pty_flag : 1; == !NILP (pty_flag) unsigned inherit_coding_system_flag : 1; == !NILP (inherit_coding_system_flag) unsigned read_output_skip : 1; == !NILP (read_output_skip) int read_output_delay; == XINT (read_output_delay) The adaptive_read_buffering field could be replaced by two new fields (which would also improve code readability): unsigned adaptive_read_buffering : 1; == !NILP (Vprocess_adaptive_read_buffering); unsigned adaptive_read_buffering_clear_on_write : 1; == EQ (Vprocess_adaptive_read_buffering, Qt) I also noticed that the field encoding_carryover is no longer used, so it can be deleted. -- Kim F. Storm http://www.cua.dk