From: "Keiichiro Nagano" <knagano@sodan.org>
Subject: init_buffer PWD fix
Date: Mon, 22 Apr 2002 05:15:17 +0900 [thread overview]
Message-ID: <m3lmbgg65m.wl@omni-engine.com> (raw)
Dear all,
init_buffer uses environmental variable PWD to identify current
working directory. I think we should not use it on Windows. On
Windows with Cygwin, PWD is unreliable and confusing, because
* Cygwin bash treats it
* Cygwin sh (ash) doesnot
* to say nothing of command.com, cmd.exe, nmake.exe and so on
How do you think?
--
Keiichiro Nagano
Index: buffer.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/buffer.c,v
retrieving revision 1.381
diff -u -u -r1.381 buffer.c
--- buffer.c 16 Apr 2002 07:34:36 -0000 1.381
+++ buffer.c 21 Apr 2002 20:13:58 -0000
@@ -4973,6 +4973,7 @@
if (NILP (buffer_defaults.enable_multibyte_characters))
Fset_buffer_multibyte (Qnil);
+#ifndef WINDOWSNT
/* If PWD is accurate, use it instead of calling getwd. This is faster
when PWD is right, and may avoid a fatal error. */
if ((pwd = getenv ("PWD")) != 0
@@ -4990,6 +4991,13 @@
else if (getwd (buf) == 0)
fatal ("`getwd' failed: %s\n", buf);
#endif
+#else /* not WINDOWSNT */
+ /* We do not use PWD on Windows because it's unreliable and
+ confusing (Cygwin bash treats it, Cygwin sh (ash) doesnot, to say
+ nothing of command.com, cmd.exe, nmake.exe and so on) */
+ if (getwd (buf) == 0)
+ fatal ("`getwd' failed: %s\n", buf);
+#endif /* not WINDOWSNT */
#ifndef VMS
/* Maybe this should really use some standard subroutine
next reply other threads:[~2002-04-21 20:15 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-21 20:15 Keiichiro Nagano [this message]
2002-04-21 23:00 ` init_buffer PWD fix Keiichiro Nagano
2002-04-22 6:18 ` Paul Eggert
2002-04-22 7:20 ` Keiichiro Nagano
2002-04-22 11:15 ` Eli Zaretskii
2002-04-22 21:16 ` Jason Rumney
2002-04-22 7:53 ` Eli Zaretskii
2002-04-22 7:01 ` Paul Eggert
2002-04-22 8:10 ` Eli Zaretskii
2002-04-22 7:22 ` Paul Eggert
2002-04-22 11:14 ` Eli Zaretskii
2002-04-22 23:21 ` Paul Eggert
2002-04-23 6:05 ` Eli Zaretskii
2002-04-22 21:21 ` Jason Rumney
2002-04-23 5:56 ` Eli Zaretskii
2002-04-23 6:14 ` MIYASHITA Hisashi
2002-04-23 11:00 ` Eli Zaretskii
2002-04-24 17:55 ` Richard Stallman
2002-04-24 18:14 ` MIYASHITA Hisashi
2002-04-23 17:45 ` Paul Eggert
2002-04-24 6:52 ` MIYASHITA Hisashi
2002-04-24 7:13 ` Paul Eggert
2002-04-24 7:45 ` MIYASHITA Hisashi
2002-04-24 11:12 ` Eli Zaretskii
2002-04-24 10:30 ` MIYASHITA Hisashi
2002-04-24 16:03 ` Eli Zaretskii
2002-04-24 17:13 ` MIYASHITA Hisashi
2002-04-24 18:10 ` Eli Zaretskii
2002-04-24 18:25 ` MIYASHITA Hisashi
2002-04-24 19:19 ` Paul Eggert
2002-04-24 19:41 ` MIYASHITA Hisashi
2002-04-24 19:59 ` MIYASHITA Hisashi
2002-04-24 20:21 ` Paul Eggert
2002-04-24 20:41 ` MIYASHITA Hisashi
2002-04-24 21:01 ` Paul Eggert
2002-04-24 21:23 ` MIYASHITA Hisashi
2002-04-24 21:35 ` MIYASHITA Hisashi
2002-04-25 22:52 ` Stefan Monnier
2002-04-25 3:42 ` Eli Zaretskii
2002-04-24 16:47 ` Paul Eggert
2002-04-24 17:55 ` MIYASHITA Hisashi
2002-04-24 10:38 ` MIYASHITA Hisashi
2002-04-24 16:08 ` Eli Zaretskii
2002-04-24 16:10 ` Eli Zaretskii
2002-04-24 7:55 ` MIYASHITA Hisashi
2002-04-24 11:07 ` Eli Zaretskii
2002-04-24 11:05 ` Eli Zaretskii
2002-04-24 10:31 ` MIYASHITA Hisashi
2002-04-24 16:05 ` Eli Zaretskii
2002-04-22 7:03 ` Eli Zaretskii
2002-04-22 6:49 ` Keiichiro Nagano
2002-04-22 8:01 ` Eli Zaretskii
2002-04-22 8:26 ` Keiichiro Nagano
2002-04-22 11:19 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3lmbgg65m.wl@omni-engine.com \
--to=knagano@sodan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).