From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Window-groups Date: Mon, 23 Jun 2008 16:29:38 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1214231424 19711 80.91.229.12 (23 Jun 2008 14:30:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 23 Jun 2008 14:30:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 23 16:31:08 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KAn48-0008RG-0k for ged-emacs-devel@m.gmane.org; Mon, 23 Jun 2008 16:30:44 +0200 Original-Received: from localhost ([127.0.0.1]:39057 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KAn3I-0002Zr-Lg for ged-emacs-devel@m.gmane.org; Mon, 23 Jun 2008 10:29:52 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KAn3E-0002ZP-Dq for emacs-devel@gnu.org; Mon, 23 Jun 2008 10:29:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KAn3C-0002ZD-3E for emacs-devel@gnu.org; Mon, 23 Jun 2008 10:29:47 -0400 Original-Received: from [199.232.76.173] (port=37738 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KAn3B-0002Z9-Tl for emacs-devel@gnu.org; Mon, 23 Jun 2008 10:29:45 -0400 Original-Received: from iwfs.imcode.com ([82.115.149.64]:55096 helo=gate.verona.se) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KAn38-0002Dr-M3; Mon, 23 Jun 2008 10:29:43 -0400 Original-Received: from chopper (IDENT:1005@localhost [127.0.0.1]) by gate.verona.se (8.13.4/8.11.4) with ESMTP id m5NETaee004837; Mon, 23 Jun 2008 16:29:37 +0200 In-Reply-To: (Richard M. Stallman's message of "Mon, 23 Jun 2008 10:14:42 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:99784 Archived-At: Richard M Stallman writes: > Please stick to our coding style. Please follow the conventions of > spacing and indentation that are used throughout the code. > > case DELETE_OTHER_WINDOWS: > - if (!EQ (window, obj)) > + if (!EQ (window, obj) ) > > There shouldn't be a space between two closeparens. > > + if(!NILP(Fwindow_parameter(window, Qgroup))) > > Please put spaces before all those openparens. Likewise in the many > similar cases. The only time an openparen should have no preceding > space is when it follows another openparen or an openbracket or a > unary operator. > > + foreach_window_1 (XWINDOW (FRAME_ROOT_WINDOW (f)), fn, user_data,allwindows); > > Please put a space after every comma. > > + else{ > > Please put the open brace on a separate line. > > > Please do not mess up the code by introducing variation in these style > questions. Please don't leave it to someone else to fix these things. These concerns will be addressed in the next version of the patch. -- Joakim Verona