Re: [PATCH] Window-groups

[joakim@verona.se]

Richard M Stallman <rms@gnu.org> writes:

> Please stick to our coding style.  Please follow the conventions of
> spacing and indentation that are used throughout the code.
>
> 	      case DELETE_OTHER_WINDOWS:
>     -	    if (!EQ (window, obj))
>     +            if (!EQ (window, obj) )
>
> There shouldn't be a space between two closeparens.
>
>     +  if(!NILP(Fwindow_parameter(window, Qgroup)))
>
> Please put spaces before all those openparens.  Likewise in the many
> similar cases.  The only time an openparen should have no preceding
> space is when it follows another openparen or an openbracket or a
> unary operator.
>
>     +    foreach_window_1 (XWINDOW (FRAME_ROOT_WINDOW (f)), fn, user_data,allwindows);
>
> Please put a space after every comma.
>
>     +      else{
>
> Please put the open brace on a separate line.
>
>
> Please do not mess up the code by introducing variation in these style
> questions.  Please don't leave it to someone else to fix these things.

These concerns will be addressed in the next version of the patch.

-- 
Joakim Verona