From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: calendar Date: Thu, 13 Jun 2019 02:18:55 +0200 Message-ID: References: <83zhn6zkgf.fsf@gnu.org> <83a7eo9nsh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="117999"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 13 02:19:28 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbDSg-000UWP-Ja for ged-emacs-devel@m.gmane.org; Thu, 13 Jun 2019 02:19:26 +0200 Original-Received: from localhost ([::1]:36274 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbDSe-0005XA-Ua for ged-emacs-devel@m.gmane.org; Wed, 12 Jun 2019 20:19:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48056) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbDSH-0005Wy-6f for emacs-devel@gnu.org; Wed, 12 Jun 2019 20:19:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hbDSF-0004x7-RG for emacs-devel@gnu.org; Wed, 12 Jun 2019 20:19:01 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:42162) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hbDSF-0004wU-JR for emacs-devel@gnu.org; Wed, 12 Jun 2019 20:18:59 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbDSB-0002mP-EY for emacs-devel@gnu.org; Thu, 13 Jun 2019 02:18:57 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEUIAwcLBQsPBgsOCA3o 4uZHOzSdko8PBw0FAQYcFRIy+KLmAAACSElEQVQ4jWXTsW7bMBAG4FO8OJsYIkO2OEYHb2WItNXO 6AUUCuAuCvBYeCiyqciiMbZAA3zb/kdKiYMeDNjmJ/4kjxC9hd67GFvjI1eLP6F3caIREDe7F+N/ jeO4av2RAGWRwD1WnfHvCeoTAwHOfe8enzrz/L4eh9VLfSqC4RlD2/VOL3D9UjdXwewBf1tTOx2M qU/rga470xRns1eC3j6BKEH5CfvpDGgAu87sb87GK0nXAM9gmjxj/3g2zww9IDI4wLcvgEO3gD0N DH6G2wsgemJA+FHS0wf47wmeT4ApQ+8SKKLQYdsMd2gMwCZ4p4JhAjQVoANAkUFXDM0CZoZ6KiUf 1P0HzebqAnis9wncZnsB7QU8zNDVLkPdMxh/2mJ3tV0Au0rlJxwQ1wbwDF2Kwri7JypiC+hdht56 mycQbUOwIerIu+qNtyiniYTYBmejVpUmvtU+WhuPohRCFKEJVmilaVy5qG69FWIl5pJCaACCix++ KREklUqCqYBxIGrtUc2Pl4IfYVjzlLwAh6BILlE0P63l8oNhWK+LopxXnQPlsvickcZVmpBgwISU ptXyPMMJ79EuvU0HrS7XiB+1VVLpHMTwcF88bH7fvWox/akOP3X1qg8JgnXBWjQVFdFalxoKuIt4 aWPYuZzn0jeDKDfiJm9G4aN4AZmjUiGBh7iRKu+qmmKc9DTvH2NKygwxVhqUBjmOT5/PgV1FzsK9 5WZJ+dHdMv1NPVH56Evb+dLSGvPNzlAsHcISKrcXg1RmUHqu1N1/5SAtZkAfImYAAAAASUVORK5C YII= In-Reply-To: (Lars Ingebrigtsen's message of "Thu, 13 Jun 2019 02:04:07 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237473 Archived-At: 22% of the remaining byte-compilation warnings (if we ignore CEDET; I swoon every time I have a peek at it) are from calendar: 78:calendar/cal-bahai.el:316:1:Warning: global/dynamic var `date' lacks= a prefix 82:calendar/cal-china.el:635:1:Warning: global/dynamic var `date' lack= s a prefix 83:calendar/cal-china.el:653:1:Warning: global/dynamic var `entry' lac= ks a prefix 86:calendar/cal-coptic.el:171:1:Warning: global/dynamic var `date' lac= ks a prefix 91:calendar/cal-french.el:246:1:Warning: global/dynamic var `date' lac= ks a prefix 97:calendar/cal-hebrew.el:751:1:Warning: global/dynamic var `date' lac= ks a prefix 98:calendar/cal-hebrew.el:759:1:Warning: global/dynamic var `entry' la= cks a 103:calendar/cal-islam.el:308:1:Warning: global/dynamic var `date' lack= s a prefix 107:calendar/cal-iso.el:132:1:Warning: global/dynamic var `date' lacks = a prefix 111:calendar/cal-julian.el:186:1:Warning: global/dynamic var `date' lac= ks a prefix 115:calendar/cal-mayan.el:356:1:Warning: global/dynamic var `date' lack= s a prefix 121:calendar/cal-persia.el:199:1:Warning: global/dynamic var `date' lac= ks a prefix 129:calendar/lunar.el:244:1:Warning: global/dynamic var `date' lacks a = prefix And they're apparently used to pass in values to specific functions; not user-defined ones which are usually the problem with these things: ;; To be called from diary-list-sexp-entries, where DATE is bound. ;;;###diary-autoload (defun diary-bahai-date () "Bah=C3=A1=E2=80=99=C3=AD calendar equivalent of date diary entry." (format "Bah=C3=A1=E2=80=99=C3=AD date: %s" (calendar-bahai-date-string d= ate))) ;; To be called from diary-list-sexp-entries, where DATE is bound. ;;;###diary-autoload (defun diary-french-date () "French calendar equivalent of date diary entry." (let ((f (calendar-french-date-string date))) (if (string-equal f "") "Date is pre-French Revolution" (format "French Revolutionary date: %s" f)))) So... I'm probably missing something here, because can't we just change the calling convention of these functions to take a `date' parameter? I don't use the calendar myself, though. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no