From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: master 32e790f: Implement NTLM server for ntlm.el testing Date: Fri, 19 Feb 2021 09:13:52 -0500 Message-ID: References: <20210219014652.27375.17475@vcs0.savannah.gnu.org> <20210219014654.0131020DFB@vcs0.savannah.gnu.org> <877dn48kw8.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32770"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 19 15:15:48 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lD6ZP-0008Pp-Qq for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Feb 2021 15:15:47 +0100 Original-Received: from localhost ([::1]:51202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD6ZO-0002GA-Hl for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Feb 2021 09:15:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD6Xl-0000zZ-GS for emacs-devel@gnu.org; Fri, 19 Feb 2021 09:14:05 -0500 Original-Received: from mail-qv1-xf2a.google.com ([2607:f8b0:4864:20::f2a]:37693) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lD6Xi-0006Lv-Ug for emacs-devel@gnu.org; Fri, 19 Feb 2021 09:14:05 -0500 Original-Received: by mail-qv1-xf2a.google.com with SMTP id s12so1977154qvq.4 for ; Fri, 19 Feb 2021 06:14:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4R1ylvXC5i8mnbUZ9W7jJuiIS+IOi/GGEfBDXetHgE0=; b=feI1wgsPDUpRLVPkIAzKz/3mqVrMjmhLYiSjRJaE6geoq+Ff5gFl/G3qvT/9Kt05bJ ZJAkCkHshsNFaKBiM1D79sC41ZVjcwHYixGJx7EWI2pmSE50i/ejjssRHHlD8xGuUhmP nwbMWECXUa/zxSDttmQHDkU8FRNwKtYA36kllSIQUj1V+KeF5h3RyCVkCii1z5csQ1BY 4lOiMkq+dngUrtzDskwGyZmXYB1qf99fcJK7L7WqjhgVHqxKaaaapH5VUwiIypM3Vgh9 jmKeqfnTy4e8jmTcfU/ijvVP4u9ZS9odDdDrsxq+kVGuxITGwOBdBt7NVYQxKbrMjdJS +VQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=4R1ylvXC5i8mnbUZ9W7jJuiIS+IOi/GGEfBDXetHgE0=; b=FtRSAitfluVirQPf1zYkuJrlC8DhbPCuiD2IffMA3A6s3os3FPHuS2oB1D2V6IXuRl kYRM3hbQrxne0tsScB/9yU8i6t9bdXrwpnrFrrIMWAld2zkKdaUJZNUSVg31MfhwdbqZ RzRPLK/1gYsuQEzIQWUqWJhkj+gmyeT/nP7+vQYWpaCgf+OQG4Y9FqLd4mkBI0KGsPwZ ZMvKjtcZzqzfFnuzfyQvvoikuYbsLf61+V8NVXjFTWEu8dN30LTx05lZqs2UrQjG4Tfw IbKHFWIpDGrVwfX5NJAXIMtFeRTjkLP37M583BW0zcjmfbhnAMXtqoFD+K8tJvTF8C/t K7vg== X-Gm-Message-State: AOAM531wqnkZpTHAKAaGm3lDrL+nj3wUcZbUUJLPOTA4iudC9eyax+ee UoiFUfsaK29aY60NDZTj4nTv8vQ3Am3H2X7T X-Google-Smtp-Source: ABdhPJyd7UQFyWjlfkJITPqsqGn3Y5LvaMjbH2adQdGF1aMdGsfACvE87T8vEyt1sVEOGwAC2bONrw== X-Received: by 2002:a0c:ee2b:: with SMTP id l11mr9240810qvs.7.1613744041220; Fri, 19 Feb 2021 06:14:01 -0800 (PST) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id r67sm6204406qkd.93.2021.02.19.06.14.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Feb 2021 06:14:00 -0800 (PST) In-Reply-To: <877dn48kw8.fsf@gmx.de> (Michael Albinus's message of "Fri, 19 Feb 2021 10:30:31 +0100") Received-SPF: none client-ip=2607:f8b0:4864:20::f2a; envelope-from=fitzsim@fitzsim.org; helo=mail-qv1-xf2a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265256 Archived-At: Michael Albinus writes: > fitzsim@fitzsim.org (Thomas Fitzsimmons) writes: > >> +Some optional tests require packages from GNU ELPA. By default >> +../../elpa will be checked for these packages. If GNU ELPA is checked >> +out somewhere else, use >> + >> + make GNU_ELPA_DIRECTORY=/path/to/elpa ... > > When I've tried it with an up-to-date checkout of emacs master, I've got > > # make -C test ntlm-tests [...] > Ran 3 tests, 1 results as expected, 2 unexpected (2021-02-19 10:07:27+0100, 0.485233 sec) > > 2 unexpected results: > FAILED ntlm-authentication > FAILED ntlm-authentication-old-compatibility-level Thanks for trying this. > Not a big deal, after pulling and recompiling recent web-server ELPA > package it was fixed. However, it makes me nervous that a checkout of > emacs master can fail tests, w/o any reason inside the sources. I realize this isn't ideal, but it's better than nothing, i.e., not being able to use GNU ELPA packages as test dependencies. And if you expand "inside the sources" to include GNU ELPA, which I assume Emacs maintainers who have an elpa checkout do, then I think it's OK (maybe even desirable?) to have to look into GNU ELPA-dependent test failures. That said, if there is no elpa.git checkout at ../elpa, or if GNU_ELPA_DIRECTORY=/nonexistent, then the tests are just skipped. (Maybe as a result of the bundling discussions, GNU ELPA will become a submodule of emacs.git which would make the dependency more reliable.) > Could you pls provide more advanced checks for dependencies? For > example, instead of > > (and (featurep 'url-http-ntlm) (featurep 'web-server)) > > you could check a proper version of the packages? I'd rather not add the complexity, e.g., depending on package.el. Beyond this first requirement to update web-server to the latest, I don't see how a version check would be useful. I tried to implement a specific check for the ws-parse functionality, but I couldn't find an easy way of confirming the new NTLM path. > Furthermore, when the ELPA packages are not present, we see in the make > test output: > > Warning (emacs): Cannot find one or more GNU ELPA packages > Warning (emacs): Skipping NTLM authentication tests > Warning (emacs): See GNU_ELPA_DIRECTORY in test/README > Running 3 tests (2021-02-19 10:26:00+0100, selector `(not (tag :unstable))') > skipped 1/3 ntlm-authentication (0.000133 sec) > skipped 2/3 ntlm-authentication-old-compatibility-level (0.000097 sec) > passed 3/3 ntlm-time-to-timestamp (0.000136 sec) > > Is it necessary to be such chatty? The tests are skipped (like other > tests), fine. I debated not putting in those warnings. I wanted to point out why the tests are being skipped, and in particular that it's easy to have them not be skipped if you have a GNU ELPA checkout (versus tests that are unavoidably skipped because they depend on a different OS or architecture). Basically, I'd like to encourage Emacs maintainers to not skip these tests; the reason I wrote them was to prevent regressions like Bug#43566 (merged with Bug#44195 and Bug#44439), which broke all uses of NTLM in an Emacs point release. Thomas