From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: +face-remapping-20040505-0.patch Date: 24 May 2004 10:15:48 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <874qqwrycm.fsf@tc-1-100.kawasaki.gol.ne.jp> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1085388017 16534 80.91.224.253 (24 May 2004 08:40:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 24 May 2004 08:40:17 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon May 24 10:40:11 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BSB0F-0007Z7-00 for ; Mon, 24 May 2004 10:40:11 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BSB0F-000242-00 for ; Mon, 24 May 2004 10:40:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BSAje-0007io-WC for emacs-devel@quimby.gnus.org; Mon, 24 May 2004 04:23:03 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34) id 1BSAja-0007iW-7U for emacs-devel@gnu.org; Mon, 24 May 2004 04:22:58 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BSAj3-0007dP-6n for emacs-devel@gnu.org; Mon, 24 May 2004 04:22:57 -0400 Original-Received: from [212.88.64.25] (helo=mail-relay.sonofon.dk) by monty-python.gnu.org with smtp (Exim 4.34) id 1BSAj2-0007dD-KA for emacs-devel@gnu.org; Mon, 24 May 2004 04:22:25 -0400 Original-Received: (qmail 25880 invoked from network); 24 May 2004 08:15:43 -0000 Original-Received: from unknown (HELO kfs-l.imdomain.dk.cua.dk) (213.83.150.2) by 0 with SMTP; 24 May 2004 08:15:43 -0000 Original-To: Miles Bader In-Reply-To: <874qqwrycm.fsf@tc-1-100.kawasaki.gol.ne.jp> Original-Lines: 27 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:23880 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:23880 Miles Bader writes: > Here's a new patch, which is re-diffed against the CVS trunk, and also > includes a bug-fix: I don't know if you sent a more recent patch than this one, but there's a bug in the patch: > +/* Return the face id of the realized face for named face SYMBOL on > + frame F suitable for displaying character C. Value is -1 if the > + face couldn't be determined, which might happen if the default face > + isn't realized and cannot be realized. */ > + > +int > +lookup_named_face (f, symbol, c) > + struct frame *f; > + Lisp_Object symbol; > + int c; > +{ > + return lookup_named_face_1 (f, symbol, c); missing arg for signal_p here----+ > +} -- Kim F. Storm http://www.cua.dk