From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: [mange@freemail.hu: grep-tree doesn't shell-quote-argument] Date: Mon, 24 Apr 2006 13:05:14 +0200 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1145876853 24768 80.91.229.2 (24 Apr 2006 11:07:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 24 Apr 2006 11:07:33 +0000 (UTC) Cc: mange@freemail.hu, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 24 13:07:29 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FXyud-0007rh-Cl for ged-emacs-devel@m.gmane.org; Mon, 24 Apr 2006 13:07:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FXyuc-0007Eo-TU for ged-emacs-devel@m.gmane.org; Mon, 24 Apr 2006 07:07:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FXyuQ-0007EL-Vs for emacs-devel@gnu.org; Mon, 24 Apr 2006 07:07:15 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FXyuO-0007Ch-4A for emacs-devel@gnu.org; Mon, 24 Apr 2006 07:07:14 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FXyuO-0007Cd-0h for emacs-devel@gnu.org; Mon, 24 Apr 2006 07:07:12 -0400 Original-Received: from [195.41.46.236] (helo=pfepb.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FXywZ-0007eX-BF; Mon, 24 Apr 2006 07:09:27 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk [80.62.38.68]) by pfepb.post.tele.dk (Postfix) with SMTP id 57752A50061; Mon, 24 Apr 2006 13:07:03 +0200 (CEST) Original-To: rms@gnu.org In-Reply-To: (Richard Stallman's message of "Sun, 23 Apr 2006 17:58:34 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53315 Archived-At: Richard Stallman writes: > The old grep-find interface is "a hack" (a way to > start a compile-like command which runs find | grep. > > But it is quite like M-x grep, and that makes for consistency. I > think that nearly everyone who uses grep-find will have used M-x grep > first, and will therefore find grep-find quite natural. Unless they also find grep quite un-natural (and unfriendly)! I do! In practice, I almost never use M-x grep, as I usually want to search in subdirectores too, and grep doesn't do that. And I find the old grep-find interface way too slow. So I use M-x grep-tree 99% of the time -- and really dislike M-x grep when I use it. > It could be the case that we could make both grep and grep-find easier > for beginners to use, in a consistent way. Yes, IMO the right approach would be to change M-x grep too to be like (the new) M-x grep-find, i.e. prompt for REGEXP + FILES, and then run grep with the proper args. A user can still use C-u M-x grep to enter the "expert mode" with the old-style shell command. And setting grep-prompt-style to 'shell will get the old behaviour of both M-x grep and M-x grep-find. Now, that would ensure consistency, and give both M-x grep and M-x grep-find a much more user friendly interface. > But let's wait till after > the release for that change. > I know we are close to starting the pretest, but since grep-tree is new, we should definitely fix this issue before the release. After the release, people will start using and customize it, so when we later clean things up, we would remove grep-tree and rename various defcustoms; that would be incompatible too! So it's now or never... > For now, I would suggest we consider making the new feature grep-tree > more convenient in a way that isn't incompatible for old features > such as grep-find. M-x grep-tree was convenient already -- but it was suggested to merge it into grep-find ... which need to make "incompatible" changes to grep-find to remain convenient. The code for grep-find is almost complete anyway -- and I can easily modify M-x grep to comply. -- Kim F. Storm http://www.cua.dk