From: joakim@verona.se
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: imagemmagick patch 5
Date: Thu, 15 Apr 2010 11:34:09 +0200 [thread overview]
Message-ID: <m3k4s9qctq.fsf@verona.se> (raw)
In-Reply-To: <m3ocj2h19h.fsf@verona.se> (joakim@verona.se's message of "Fri, 05 Mar 2010 23:06:18 +0100")
joakim@verona.se writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> The Imagemagick patch allows Emacs to use the Imagemagick libraries to
>>> load images. This support can be used in parallell with the existing
>>> image loading support. There is support for asking your imagemagick
>>> installation which image types it supports, and registering them in
>>> Emacs selectively.
>>
>> Thanks. Looks pretty good. Feel free to install it in the `pending'
>> branch, but please see the comments below first, and don't forget to add
>> a good NEWS entry when you install this change.
>
> Ok. I will need to read up on bzr before committing.
I've done a local bzr branch now, called "imagemagick". I would now like
to publish this branch.
http://www.emacswiki.org/emacs/BzrForEmacsDevs
mentions ways of publishing a branch to launchpad etc, but I cant find
how to publish it on savannah. Could some kind soul enlighten me?
> Could you possibly also comment on the interface I chose for scaling and
> rotation? If they are ok, I will document them in the NEWS entry. I
> assume the "index" spec is ok since that is also used for gifs already.
>
> Also please comment if the interface to select which image types
> imagemagick gets to handle is ok.
>
>>
>>> +HAVE_IMAGEMAGICK=no
>>> +if test "${HAVE_X11}" = "yes" ; then
>>
>> Do I understand it right that this X11-only restriction could be lifted
>> at some point in the future?
>
> Yes. Theres nothing completely X specific in the patch I think, just the
> same type of bitmap manipulations that goes on for the other image
> libraries.
>
>>> diff --git a/src/dbusbind.c b/src/dbusbind.c
>>> index 7c0be49..7a47730 100644
>>> --- a/src/dbusbind.c
>>> +++ b/src/dbusbind.c
>>> @@ -773,6 +773,7 @@ xd_add_watch (watch, data)
>>> if (fd == -1)
>>> return FALSE;
>>>
>>> +
>>> /* Add the file descriptor to input_wait_mask. */
>>> add_keyboard_wait_descriptor (fd);
>>> }
>>
>> Please drop this gratuitous change.
>
> Hmm, I have no idea how this crept in. Odd.
>
>
>>> +/***********************************************************************
>>> + imagemagick
>>> + ***********************************************************************/
>>> +#if defined (HAVE_IMAGEMAGICK)
>>> +Lisp_Object Vimagemagick_render_type;
>>> +/* Function prototypes. */
>>> +
>>> +static int imagemagick_image_p P_ ((Lisp_Object object));
>>> +static int imagemagick_load P_ ((struct frame *f, struct image *img));
>>> +
>>> +static int imagemagick_load_image P_ ((struct frame *, struct image *,
>>> + unsigned char *, unsigned int, unsigned char *));
>>
>> Please don't use the P_ macro in new code: just use prototypes.
>
> Ok. Like this?
>
> static int imagemagick_image_p (Lisp_Object object);
> static int imagemagick_load (struct frame *f, struct image *img);
>
> static int imagemagick_load_image (struct frame *, struct image *,
> unsigned char *, unsigned int, unsigned char *);
>
>
>>> +//#include "/home/joakim/current/unison/data/ImageMagick-6.5.4-7/magick/xwindow-private.h"
>>
>> This should be removed as well.
>
> Ok.
>
>>> + //try if magicexportimage is any faster than pixelpushing
>> [...]
>>> + //oddly, the below code doesnt seem to work:
>>
>> We currently only use /*...*/ comments, so I'd rather we don't introduce
>> // comments for now.
>>
>
> Sorry, I keep forgetting this, it seems to be in my muscle memory.
>
>> Stefan
>>
--
Joakim Verona
next prev parent reply other threads:[~2010-04-15 9:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 7:39 imagemmagick patch 5 joakim
2010-03-03 19:34 ` Juri Linkov
2010-03-03 20:03 ` joakim
2010-03-06 17:59 ` Juri Linkov
2010-03-06 20:16 ` Stefan Monnier
2010-03-06 21:05 ` Juri Linkov
2010-03-07 14:37 ` Stefan Monnier
2010-03-07 19:08 ` Juri Linkov
2010-03-07 21:23 ` Stefan Monnier
2010-03-13 17:44 ` Kim F. Storm
2010-03-30 16:12 ` Image metadata (was: imagemmagick patch 5) Juri Linkov
2010-03-30 20:36 ` Image metadata Stefan Monnier
2010-03-30 22:38 ` Juri Linkov
2010-03-31 1:22 ` Stefan Monnier
2010-04-02 21:51 ` joakim
2010-04-02 22:38 ` Juri Linkov
2010-03-04 2:41 ` imagemmagick patch 5 Stefan Monnier
2010-03-05 22:06 ` joakim
2010-03-05 22:30 ` Stefan Monnier
2010-03-05 23:56 ` Jan Djärv
2010-03-06 6:02 ` Stephen J. Turnbull
2010-04-15 9:34 ` joakim [this message]
2010-04-15 10:55 ` joakim
2010-04-16 20:45 ` Juri Linkov
2010-04-17 6:09 ` joakim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k4s9qctq.fsf@verona.se \
--to=joakim@verona.se \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).