From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r104665: Rewritten smtpmail.el to use `open-network-stream' to do STARTTLS Date: Thu, 23 Jun 2011 03:03:45 +0200 Organization: Programmerer Ingebrigtsen Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1308791063 6287 80.91.229.12 (23 Jun 2011 01:04:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 23 Jun 2011 01:04:23 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 23 03:04:20 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QZYLD-0002cp-Na for ged-emacs-devel@m.gmane.org; Thu, 23 Jun 2011 03:04:19 +0200 Original-Received: from localhost ([::1]:41961 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZYLC-0003Mv-Tw for ged-emacs-devel@m.gmane.org; Wed, 22 Jun 2011 21:04:19 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:47760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZYKv-0003Md-Dp for emacs-devel@gnu.org; Wed, 22 Jun 2011 21:04:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QZYKt-00029q-Hm for emacs-devel@gnu.org; Wed, 22 Jun 2011 21:04:01 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:35654) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZYKt-00029i-1J for emacs-devel@gnu.org; Wed, 22 Jun 2011 21:03:59 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QZYKq-0002RQ-PV for emacs-devel@gnu.org; Thu, 23 Jun 2011 03:03:56 +0200 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 23 Jun 2011 03:03:56 +0200 Original-Received: from larsi by cm-84.215.51.58.getinternet.no with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 23 Jun 2011 03:03:56 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 23 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: cm-84.215.51.58.getinternet.no Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEUsLHqSlmO0tncXGV5u bWxSS2cHBikhJHQkUGcxAAACNElEQVQ4jV2TTY/aMBCGhy7IVxzZ2nPQ5N4qobnWriOuaxPEGe3C GSmL8vc7M04gqiWENY/f+Xgdw22xKtXe1ShrgEX8a6daDgpcAuPf23GWLMDFoqnHeS2ASz6ep7Ba gKutTGUncF6AlEIZ3CQ5vMAVUXsXthJ/LMDFB4sWtTSVFqmMd2nnUnxnsHkVv1BhJFGl/2tX++QD 4ix5ggv1GnyRIv1TtH0CnWLAylGmFA8LBQk4F2eah4TJDQoY9CQxky8CvrLAIGcKWSIgJjpaFm4n xY34AmIf0kmTi/uYgp0AC8go7zBnQp3bvZqySM4goudMPg9JgNpkZ32BFWcSX1oC13JXUBYsvaMw CzVL4JaKErHw1Cw6UXpHyhFgZSsbYtN3ne2tpS33rBXAG7dibUU1825KBW8rGYrPiSE8rB5YAXko doXbJSfdlgFV4dvj2dkqxxcPw8hgI0ORW1yVts6OGUAeKiWd3ddn+lQEbGYXOZc3luIK7kxYTh2l nOtD7kPAt1y2zzqrXkDJ3ZbSs+vX8nDyWnHIa8n1qz/WdT0BYDdKKU7Rz/r2BDSk2Ykbdr0/Nac6 12AJXZF8oV2z7mOoYaqiVnQfXFwNN86UATmmHoaNcVvoup6rMLjLN5no5lB/QN81GczrYbEPFtSx /vnJ7Y55TvpFfs4Adt80DB6nPLu6f2NlaHPaN3sGmxPQcaBHB0X8A+redd3fGUzrh6E2CByO9fCc nGSw4ec3/KbjbV3/A0mXGjBE33u+AAAAAElFTkSuQmCC Mail-Copies-To: never X-Now-Playing: Tied + Tickled Trio + Billy Hart's _La Place Demon_: "The Three Doors pt. 1" User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:oNAIVNaMdlTJWcpKbuVCBM/E2ps= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:140898 Archived-At: Katsumi Yamaoka writes: >> + (setq result >> + (open-network-stream >> + "smtpmail" process-buffer host port >> + :type smtpmail-stream-type >> + :return-list t > > I've been using smtpmail with replacing `open-network-stream' with > `my-open-network-stream'. You had defaliased `open-network-stream' to `my-open-network-stream'? In that case, wouldn't calling `my-open-network-stream' break here, too, since the caller now supplies all those extra keywork parameters that weren't present in the old `open-network-stream'? Anyway, I think your patch is otherwise fine, but I'm not sure how needed it is. I mean, anybody who's aliased `open-network-stream' could be expected to fix the calling sequence and return values. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/