From: Daiki Ueno <ueno@gnu.org>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: emacs-devel@gnu.org
Subject: Re: XCHAR2B_BYTE[12] definitions in NS
Date: Wed, 16 Jul 2014 14:46:43 +0900 [thread overview]
Message-ID: <m3k37dvosc.fsf-ueno@gnu.org> (raw)
In-Reply-To: <m3pph6ueh2.fsf-ueno@gnu.org> (Daiki Ueno's message of "Wed, 16 Jul 2014 13:14:49 +0900")
Daiki Ueno <ueno@gnu.org> writes:
> Jan Djärv <jan.h.d@swipnet.se> writes:
>
>> They are used in xdisp.c which is generic code.
>> W32 has similar macros. Maybe move to a common h-file and remove w32
>> and ns-specific macros?
>
> Makes sense, thanks for the suggestion. I've pushed a patch in that way
> (r117538).
I missed the fact that s->char2b is directly passed to the
platform-dependent drawing functions: ExtTextOutW (W32) and
CGContextShowGlyphsWithAdvances (NS), and the corresponding argument
types are also platform-dependent: wchar_t * (W32) and unichar * (NS).
So, IMO merging the macros into a single place will cause more
confusion. I reverted the change and just installed the parentheses fix
I initially posted. Sorry for all the fuss.
Regards,
--
Daiki Ueno
prev parent reply other threads:[~2014-07-16 5:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 9:02 XCHAR2B_BYTE[12] definitions in NS Daiki Ueno
2014-07-15 13:20 ` Jan Djärv
2014-07-16 4:14 ` Daiki Ueno
2014-07-16 5:46 ` Daiki Ueno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k37dvosc.fsf-ueno@gnu.org \
--to=ueno@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).