From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: feedmail Date: Sat, 15 Jun 2019 17:28:13 +0200 Message-ID: References: <83a7eo9nsh.fsf@gnu.org> <831rzvvsgp.fsf@gnu.org> <83y322vqvg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="70442"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 15 17:28:27 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcAbT-000IAU-Q2 for ged-emacs-devel@m.gmane.org; Sat, 15 Jun 2019 17:28:27 +0200 Original-Received: from localhost ([::1]:32772 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcAbS-00052t-S7 for ged-emacs-devel@m.gmane.org; Sat, 15 Jun 2019 11:28:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60939) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcAbN-00050c-08 for emacs-devel@gnu.org; Sat, 15 Jun 2019 11:28:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcAbL-0005Pq-Ug for emacs-devel@gnu.org; Sat, 15 Jun 2019 11:28:20 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:32926) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hcAbL-00053b-No; Sat, 15 Jun 2019 11:28:19 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcAbF-0007oU-9a; Sat, 15 Jun 2019 17:28:15 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUUDAwoFReFOjcMBgXL a11aJiaNjLxJAAACWUlEQVQ4jW2UTZLjIAyFRdzZQ9I+ACrYkya5gErsByrc/yrzhJ2ezbBwEj7r /ymU5/8Od+rh9xBO8PZ0+BEIXz05d9yc931dE115zk6zw0nPhw+6E23llThFx8zzzZkj7j0stlpf SbTvg7uB0UK4F7pXnBcL9zBymCP3GyzqAejFKr3f3sqD4y06XwgAj2tSiXlX4cSTo+VDd4f8f1S1 z5s2zYgUCU7I6qoPgDiSzozMJNKGnCyz+jJwU0UOcwCgbICwLZAB9r5PWKw64GqriCE5qc4+DFjY FWMDyG/VNnKbSaJ3ZzsRXKZ5w+uDrSWejuBPFRjoxK0Bd4KtPoUBxABOXB1fA3pKhkGbuE3MaOKq I5jFAoeBtjU/PGr9kbFqx7AZL5gj2KC9T02W1LDnB6x5fElS1uMIgIlhgYsMSSdIZvEBP9r1BHIA f7rS+O/+1xXV8mVNZ3PDegBH922BfLN32Vp8Ar8VAMkXSSyT9QSIAVmVi8SLKMc9fYApERZX7ReR HMZpYVn5ZQHABlZibYnbwGOX8IX27XwAt3QF4K7ZfzNDcav0tjbFLzB9GmnaFCHG5lcTIRK69l1t B8xgJIsBUACcfwuPbCESf+owCxeElZseIJ51bIXctwjmkFYTpS9N+WWBzYBurVtJJnRFZY2WnCmk oTzMPs9usl3pYlBhQM8I8G69m9SOAqH2ncPOjWeK+/TwUsyi0EsCFjPnjP3csfFn5Q96NfdnH4iD hZsWoSwQ6IKVQXQs827/CweAN+ixFnwn6wI+EdX2/FFdLXX9sNV+4B5x/wKuJbN8Ljru7QAAAABJ RU5ErkJggg== In-Reply-To: <83y322vqvg.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Jun 2019 17:56:51 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237692 Archived-At: Eli Zaretskii writes: > Sounds like this bug was caused by converting feedmail to > lexical-binding? Hm... I don't think so: It's funcalling the wrong symbol, in essence doing (funcall (let ((helper 'message)) 'helper)) I think the fix is pretty trivial: diff --git a/lisp/mail/feedmail.el b/lisp/mail/feedmail.el index 943bdd8851..6f50c3e4ed 100644 --- a/lisp/mail/feedmail.el +++ b/lisp/mail/feedmail.el @@ -2170,7 +2170,7 @@ feedmail-queue-send-edit-prompt-inner (if (= user-sez help-char) ;; FIXME: This seems to want to refer to the `helper' argument, ;; but it's quoted so the `helper' arg ends up unused! - (setq answer '(^ . helper)) + (setq answer (cons '^ helper)) (if (or (eq user-sez ?\C-m) (eq user-sez ?\C-j) (eq user-sez ?y)) (setq user-sez d-char)) ;; these char-to-int things are because of some but it would be nice to have someone confirm that this analysis is right before doing anything. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no