From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] EUDC email addresses via completion-at-point in message-mode Date: Tue, 03 May 2022 14:03:36 -0400 Message-ID: References: <6470ea4f4595563fe0a2d20a33385afb@condition-alpha.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34753"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Filipp Gunbin , emacs-devel@gnu.org To: Alexander Adolf Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 03 20:07:31 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlwvr-0008o0-G0 for ged-emacs-devel@m.gmane-mx.org; Tue, 03 May 2022 20:07:31 +0200 Original-Received: from localhost ([::1]:50060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nlwvq-0007w0-AK for ged-emacs-devel@m.gmane-mx.org; Tue, 03 May 2022 14:07:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlwsB-0008Dq-Gi for emacs-devel@gnu.org; Tue, 03 May 2022 14:03:43 -0400 Original-Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]:41648) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nlws9-00077m-3x for emacs-devel@gnu.org; Tue, 03 May 2022 14:03:43 -0400 Original-Received: by mail-qk1-x731.google.com with SMTP id f186so14338050qke.8 for ; Tue, 03 May 2022 11:03:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=VvzqgGCfLTJS2/sYvmtrOwVOArBjkw6FGITLrlrae5s=; b=6/TBxsK2dtoyStRYbTyrGftiKOltK5aHddpgf5NmYh0cLxYobpt6z1bI9FCT5pJycB HB9L7wnLArhVlgth0hSvyAV0SSGBbZhcupbLT+XOJgp+IOWnHDK660sLV/71dhrl3UNK k59fwKDKh1gOLsoK9hqEOaqGu22Ikft8jkLnsP0DR3Z8j8drG1Ch07UMVbSZkNHvmoyO UO3FpXbqYhK5RQRbATsIaYgLrxljZJSOj2qE4Di+w6mPeby1dTtfDszyKUE7phtgiiHo cdOmq2sdxxtnfmheMjYKBGdPf3cecN2NX+svSF21O54AhVEL9jxXLfZ9bzu/UAdRGzvn haiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=VvzqgGCfLTJS2/sYvmtrOwVOArBjkw6FGITLrlrae5s=; b=QdyNv2lCTGiQSfb5wfWSWEajy6yT/N9BPudDuo8CTdz36+d/GFiOTdlZmTYS5t6wvq ALDl5a1yqcwcifU9OMOoiNpcDvQ5kbrQrs1qbTeV+yI08TBbAZoHzMfjubKKFWD8oauw sJCCa65TWwjVTqp02CDWxDYRtirwQ7rwZt7kdExCT2HVqpu7NeV4fkxUJ7kLaU15NKv+ Od1VFlqyBu66LWH4oW85PYYWJoIXdMz7oWtKSyyD4JWZs0N3SAjz5TMUyGEe60GuFRG+ Pb78gtIvHMRyH7oEVKtjaPWPTzAmgu6JGDVXH4b3E2irzwPO393hH8b64E7zvnapNx7Z I/GA== X-Gm-Message-State: AOAM532leCvYE7g7Ik/bs6vCFshg5ZBDxbk4x41UpSVv11c9gX5wm9N/ z4j6B+C0MtPdNT7lCrSDem41Gs7a1ts65Q== X-Google-Smtp-Source: ABdhPJx4WxyjUvxKcZKtT0hTQprd21sVoITBZn3IFWaY8IgN5++CyBDN0y2jawFxRMcSIJei5FAx/A== X-Received: by 2002:a05:620a:1a06:b0:69f:b536:af3c with SMTP id bk6-20020a05620a1a0600b0069fb536af3cmr12980042qkb.772.1651601018998; Tue, 03 May 2022 11:03:38 -0700 (PDT) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id h9-20020ae9ec09000000b0069fc13ce246sm6252877qkg.119.2022.05.03.11.03.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 May 2022 11:03:37 -0700 (PDT) In-Reply-To: <6470ea4f4595563fe0a2d20a33385afb@condition-alpha.com> (Alexander Adolf's message of "Mon, 02 May 2022 19:10:19 +0200") Received-SPF: pass client-ip=2607:f8b0:4864:20::731; envelope-from=fitzsim@fitzsim.org; helo=mail-qk1-x731.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289118 Archived-At: Hi Alexander, Alexander Adolf writes: > Thomas Fitzsimmons writes: > >> [...] >> One open issue I had when I tested the prior patch was the fact that >> repeated completion attempts would query the LDAP search on each >> attempt, even if the completion table could already have been >> populated with all relevant LDAP entries. >> [...] > > Fully agree that that's inefficient and impairs the user experience. It > shouldn't happen, but seems to depend on the user interface. > > I do get a completions buffer popped up when calling either of the > functions completion-at-point or message-tab (see attached). > > What is your value of the variable completion-auto-help? It is t. > Dies changing the value of the variable message-expand-name-standard-ui > change anything for you? It is currently nil. > Which function gets called when you press TAB? message-tab? The behaviour I described was when I was testing with TAB bound to message-tab, yes. Can you reproduce the scenario in your screenshot, then subsequently type '-' then TAB, to complete on "emacs-" instead of "emacs"; I think the completion backends will be queried again. That's what I want to avoid (if that doesn't happen for you, then I'll have to recreate my testing environment and test more carefully with all the combinations of the above variables, I guess). Did you confirm completion-table-with-cache is doing something? If so, do you mind adding a comment within eudc-capf-message-expand-name's body, describing what the caching is doing, when the cache is invalidated, etc.? Thanks, Thomas