Re: [PATCH] EUDC email addresses via completion-at-point in message-mode

[Thomas Fitzsimmons <fitzsim@fitzsim.org>]

Hi Alexander,

Alexander Adolf <alexander.adolf@condition-alpha.com> writes:

> Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
>
>> [...]
>> One open issue I had when I tested the prior patch was the fact that
>> repeated completion attempts would query the LDAP search on each
>> attempt, even if the completion table could already have been
>> populated with all relevant LDAP entries.
>> [...]
>
> Fully agree that that's inefficient and impairs the user experience. It
> shouldn't happen, but seems to depend on the user interface.
>
> I do get a completions buffer popped up when calling either of the
> functions completion-at-point or message-tab (see attached).
>
> What is your value of the variable completion-auto-help?

It is t.

> Dies changing the value of the variable message-expand-name-standard-ui
> change anything for you?

It is currently nil.

> Which function gets called when you press TAB? message-tab?

The behaviour I described was when I was testing with TAB bound to
message-tab, yes.

Can you reproduce the scenario in your screenshot, then subsequently
type '-' then TAB, to complete on "emacs-" instead of "emacs"; I think
the completion backends will be queried again.  That's what I want to
avoid (if that doesn't happen for you, then I'll have to recreate my
testing environment and test more carefully with all the combinations of
the above variables, I guess).

Did you confirm completion-table-with-cache is doing something?  If so,
do you mind adding a comment within eudc-capf-message-expand-name's
body, describing what the caching is doing, when the cache is
invalidated, etc.?

Thanks,
Thomas