From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Madhu Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 f050b9c5033: Fix Tramp IPv6 handling in tests Date: Mon, 05 Aug 2024 20:00:38 +0530 Message-ID: References: <172163502862.25672.12565431460737995012@vcs2.savannah.gnu.org> <20240722075709.1C23CC41F06@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28935"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Cancel-Lock: sha1:lVtGkBkPMGNMxRlxrD6M857ULIY= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 05 16:54:18 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1saz6H-0007Ot-Vr for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Aug 2024 16:54:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1saz5V-0003kv-7r; Mon, 05 Aug 2024 10:53:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sayjr-0005a8-0r for emacs-devel@gnu.org; Mon, 05 Aug 2024 10:31:07 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sayjp-0005BK-08 for emacs-devel@gnu.org; Mon, 05 Aug 2024 10:31:06 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1sayjn-0003g6-9X for emacs-devel@gnu.org; Mon, 05 Aug 2024 16:31:03 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 05 Aug 2024 10:53:28 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322370 Archived-At: * Michael Albinus via Mailing list for Emacs changes <20240722075709.1C23CC41F06@vcs2.savannah.gnu.org> : Wrote on Mon, 22 Jul 2024 03:57:08 -0400 (EDT): > branch: emacs-30 > commit f050b9c5033ef92ac299d3da30774bc228fd0e08 > Author: Michael Albinus > diff --git a/lisp/net/tramp-integration.el b/lisp/net/tramp-integration.el > --- a/lisp/net/tramp-integration.el > +++ b/lisp/net/tramp-integration.el > @@ -275,9 +275,14 @@ NAME must be equal to `tramp-current-connection'." > ;;; Integration of shortdoc.el: > > (with-eval-after-load 'shortdoc > - (dolist (elem '((file-remote-p > + (dolist (elem `((file-remote-p > :eval (file-remote-p "/ssh:user@host:/tmp/foo") > - :eval (file-remote-p "/ssh:user@host:/tmp/foo" 'method)) > + :eval (file-remote-p "/ssh:user@host:/tmp/foo" 'method) > + :eval (file-remote-p "/ssh:user@[::1]#1234:/tmp/foo" 'host) > + ;; We don't want to see the text properties. > + :no-eval (file-remote-p "/sudo::/tmp/foo" 'user) > + :result ,(substring-no-properties > + (file-remote-p "/sudo::/tmp/foo" 'user))) just a caveat that substring-no-properties can end up being called on nil here. I agree it is unlikely, but I managed to trigger it with the `swiper' package, where an unconditional (require 'tramp) in the midst of code kept failing.