unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Madhu <enometh@meer.net>
To: emacs-devel@gnu.org
Subject: Re: emacs-30 f050b9c5033: Fix Tramp IPv6 handling in tests
Date: Mon, 05 Aug 2024 20:00:38 +0530	[thread overview]
Message-ID: <m3jzgvkpo1.fsf@leonis4.robolove.meer.net> (raw)
In-Reply-To: 20240722075709.1C23CC41F06@vcs2.savannah.gnu.org

* Michael Albinus via Mailing list for Emacs changes <20240722075709.1C23CC41F06@vcs2.savannah.gnu.org> :
Wrote on Mon, 22 Jul 2024 03:57:08 -0400 (EDT):
> branch: emacs-30
> commit f050b9c5033ef92ac299d3da30774bc228fd0e08
> Author: Michael Albinus <michael.albinus@gmx.de>
> diff --git a/lisp/net/tramp-integration.el b/lisp/net/tramp-integration.el
> --- a/lisp/net/tramp-integration.el
> +++ b/lisp/net/tramp-integration.el
> @@ -275,9 +275,14 @@ NAME must be equal to `tramp-current-connection'."
>  ;;; Integration of shortdoc.el:
>
>  (with-eval-after-load 'shortdoc
> -  (dolist (elem '((file-remote-p
> +  (dolist (elem `((file-remote-p
>  		   :eval (file-remote-p "/ssh:user@host:/tmp/foo")
> -		   :eval (file-remote-p "/ssh:user@host:/tmp/foo" 'method))
> +		   :eval (file-remote-p "/ssh:user@host:/tmp/foo" 'method)
> +		   :eval (file-remote-p "/ssh:user@[::1]#1234:/tmp/foo" 'host)
> +		   ;; We don't want to see the text properties.
> +		   :no-eval (file-remote-p "/sudo::/tmp/foo" 'user)
> +		   :result ,(substring-no-properties
> +			     (file-remote-p "/sudo::/tmp/foo" 'user)))

just a caveat that substring-no-properties can end up being called on
nil here.  I agree it is unlikely, but I managed to trigger it with the
`swiper' package, where an unconditional (require 'tramp) in the midst
of code kept failing.





       reply	other threads:[~2024-08-05 14:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <172163502862.25672.12565431460737995012@vcs2.savannah.gnu.org>
     [not found] ` <20240722075709.1C23CC41F06@vcs2.savannah.gnu.org>
2024-08-05 14:30   ` Madhu [this message]
2024-08-05 16:57     ` emacs-30 f050b9c5033: Fix Tramp IPv6 handling in tests Michael Albinus
2024-08-05 18:21       ` Michael Albinus
2024-08-06  2:41         ` Madhu
2024-08-06 14:08           ` Michael Albinus
2024-08-07 15:21             ` Madhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3jzgvkpo1.fsf@leonis4.robolove.meer.net \
    --to=enometh@meer.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).