From: storm@cua.dk (Kim F. Storm)
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Code inspection: W32 specific problems
Date: Tue, 19 Jul 2005 10:51:09 +0200 [thread overview]
Message-ID: <m3irz7rxfm.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <42DC5135.5050802@comcast.net> (David Hunter's message of "Mon, 18 Jul 2005 21:02:45 -0400")
David Hunter <hunterd_42@comcast.net> writes:
> Kim F. Storm wrote:
>>>Qw32_charset_default was declared in w32term.c rev 1.62 in early
>>>2000, but was not defined there either. It is potentially used by
>>>several codepaths, notably in enum_font_cb2(). The related symbol
>>>'w32-charset-default' also exists in documentation. It should be
>>>defined.
>> What about its initial value?
>> Is it always set from lisp before first usage?
>
> Hmm, I think I might have used the wrong terms to describe the
> issue. My grip on eLisp is not yet that strong (and probably never
> will be :) ).
No, you were correct -- I didn't look at the actual code, so
I incorrectly assumed that the code looked at the value of
w32-charset-default (as a lisp variable). It only uses the
symbol itself.
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
next prev parent reply other threads:[~2005-07-19 8:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-12 12:44 Code inspection: W32 specific problems Kim F. Storm
2005-07-12 18:59 ` Eli Zaretskii
2005-07-12 22:28 ` Stefan Monnier
2005-07-13 8:10 ` Kim F. Storm
2005-07-16 11:32 ` Eli Zaretskii
2005-07-16 17:16 ` David Hunter
2005-07-18 12:29 ` Kim F. Storm
2005-07-19 1:02 ` David Hunter
2005-07-19 8:51 ` Kim F. Storm [this message]
2005-07-19 3:37 ` Eli Zaretskii
2005-07-19 8:55 ` Kim F. Storm
2005-07-19 17:14 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3irz7rxfm.fsf@kfs-l.imdomain.dk \
--to=storm@cua.dk \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).