From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Tool-bar buttons unresponsive with tooltips on Date: Thu, 20 Oct 2005 15:45:33 +0200 Message-ID: References: <29911216.1129711174895.JavaMail.www@wwinf0202> <4356830F.3000002@swipnet.se> <6752BDE2-0EF5-47FF-BB01-F9050E7A4026@swipnet.se> <87k6g9unq8.fsf_-_@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1129818197 26136 80.91.229.2 (20 Oct 2005 14:23:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 20 Oct 2005 14:23:17 +0000 (UTC) Cc: Emacs Devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 20 16:23:11 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ESbGV-0006RR-Pi for ged-emacs-devel@m.gmane.org; Thu, 20 Oct 2005 16:19:32 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ESbGV-00088Z-4Y for ged-emacs-devel@m.gmane.org; Thu, 20 Oct 2005 10:19:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ESakP-0000n3-4H for emacs-devel@gnu.org; Thu, 20 Oct 2005 09:46:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ESakM-0000l6-Oj for emacs-devel@gnu.org; Thu, 20 Oct 2005 09:46:20 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ESakM-0000kM-4m for emacs-devel@gnu.org; Thu, 20 Oct 2005 09:46:18 -0400 Original-Received: from [195.41.46.235] (helo=pfepa.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ESakM-0006Hl-4u for emacs-devel@gnu.org; Thu, 20 Oct 2005 09:46:18 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepa.post.tele.dk (Postfix) with SMTP id 6ED9047FE3C; Thu, 20 Oct 2005 15:46:10 +0200 (CEST) Original-To: Chong Yidong In-Reply-To: <87k6g9unq8.fsf_-_@stupidchicken.com> (Chong Yidong's message of "Wed, 19 Oct 2005 18:49:03 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:44419 Archived-At: Chong Yidong writes: > This patch fixes the bug. However, it's pure hackery since I'm not > familiar with the code at all. Can someone tell me if it makes sense > to do this? It seems like you got the test wrong -- this looks more correct to me: if (NILP (tip_frame) !! frame != XFRAME (tip_frame)) remember_mouse_glyph (frame, event->x, event->y, &last_mouse_glyph); Does it still fix the bug with this change? If so, feel free to install the change with a suitable comment explaining why it is needed. > > *** emacs/src/xterm.c.~1.884.~ 2005-10-17 08:54:26.000000000 -0400 > --- emacs/src/xterm.c 2005-10-19 18:45:30.000000000 -0400 > *************** > *** 3609,3615 **** > last_mouse_scroll_bar = Qnil; > note_mouse_highlight (frame, event->x, event->y); > /* Remember which glyph we're now on. */ > ! remember_mouse_glyph (frame, event->x, event->y, &last_mouse_glyph); > return 1; > } > > --- 3609,3616 ---- > last_mouse_scroll_bar = Qnil; > note_mouse_highlight (frame, event->x, event->y); > /* Remember which glyph we're now on. */ > ! if (!NILP (tip_frame) && frame != XFRAME (tip_frame)) > ! remember_mouse_glyph (frame, event->x, event->y, &last_mouse_glyph); > return 1; > } -- Kim F. Storm http://www.cua.dk