unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org
Subject: Re: Getting the click position in a string
Date: Wed, 26 Apr 2006 13:32:44 +0200	[thread overview]
Message-ID: <m3irowk1wj.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <85fyk0rbrk.fsf@lola.goethe.zz> (David Kastrup's message of "Wed, 26 Apr 2006 10:17:51 +0200")

David Kastrup <dak@gnu.org> writes:

>> Am I wrong here?

I think I answered that... (answer: yes)

>
> On another tangent, is this change ok?  For implementing follow-link,
> I need to take a look at the follow-link binding in the keymap of a
> click, not the binding of the click itself.

Looks ok to me.
> Incidentally, this function looks faulty: it should search the keymap
> _and_ the local-map property (in _that_ order) instead of searching at
> most one of the two, even if that search would fail.

I think the rationale is that one assumes that a user would only add
either a keymap or a local-map property -- but in any case, it should
look for the keymap property before the local-map property.

But it seems easy to fix it to DTRT.

> Apart from fixing it and adding an optional key argument, is help.el
> the right place for it?

For what?

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

  reply	other threads:[~2006-04-26 11:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-25  9:53 Getting the click position in a string David Kastrup
2006-04-25 14:36 ` Kim F. Storm
2006-04-25 14:55   ` David Kastrup
2006-04-26  8:13     ` Kim F. Storm
2006-04-26  8:17 ` David Kastrup
2006-04-26 11:32   ` Kim F. Storm [this message]
2006-04-26 11:56     ` David Kastrup
2006-04-26 12:52       ` David Kastrup
2006-04-26 12:54         ` David Kastrup
2006-04-26 13:58         ` Stefan Monnier
2006-04-27 12:08           ` David Kastrup
2006-04-27 16:05             ` Stefan Monnier
2006-04-27 18:33               ` David Kastrup
2006-04-27 21:24                 ` Stefan Monnier
2006-04-27 21:39                   ` David Kastrup
2006-04-28 16:16                     ` Stefan Monnier
2006-04-29 21:55                       ` David Kastrup
2006-04-29 23:33                         ` Stefan Monnier
2006-04-30 21:55                           ` David Kastrup
2006-05-01  0:48                             ` Stefan Monnier
2006-05-01  5:55                               ` David Kastrup
2006-05-01 12:52                                 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3irowk1wj.fsf@kfs-l.imdomain.dk \
    --to=storm@cua.dk \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).